Mixins: Do not crash when a mixin has no associated handler #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially it made sense to crash, but after some experience this is not a viable solution. There is usually a bit of time between when the mixin is created and when `.attach()` is called. If the mixin attempts to run in between this period, it would lead to a crash, however this is not user error. To fix this, all generated mixins now check with `JSLoader` to see if they have an attached method before attempting to invoke it. If there is no attached method yet, the mixin will act as if it did not exist (e.g. do nothing for inject mixins, call the original method for redirect mixins, etc). With this change, CT users can now inject into places that are invoked early in the startup process, such as MinecraftClient.setScreen (which is invoked in the MinecraftClient constructor).
mattco98
force-pushed
the
mixin-without-attach
branch
from
650dc25
to
bda6ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially it made sense to crash, but after some experience this is not
a viable solution. There is usually a bit of time between when the mixin
is created and when
.attach()is called. If the mixin attempts to runin between this period, it would lead to a crash, however this is not
user error.
To fix this, all generated mixins now check with
JSLoaderto see ifthey have an attached method before attempting to invoke it. If there is
no attached method yet, the mixin will act as if it did not exist (e.g.
do nothing for inject mixins, call the original method for redirect
mixins, etc).
With this change, CT users can now inject into places that are invoked
early in the startup process, such as
MinecraftClient.setScreen(whichis invoked in the
MinecraftClientconstructor).