-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #5901
Dev #5901
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,10 @@ import { getBuildConfig } from "./config/build"; | |
const buildConfig = getBuildConfig(); | ||
|
||
export const metadata = { | ||
title: "ChatGPT Next Web", | ||
title: "ChatGPT", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Update package.json to maintain consistent branding Found inconsistency in package.json where the package name is still "chatgpt-next-web". While this doesn't affect the user-facing branding, it should be updated to maintain consistency with the simplified branding approach.
🔗 Analysis chainVerify consistent branding across the application The title simplification from "ChatGPT Next Web" to "ChatGPT" is implemented correctly. However, we should ensure this branding change is consistently applied across all application assets. Also applies to: 13-13 Let me search for any other potential branding references using a different approach. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any remaining instances of old branding
# Search for any remaining instances of "ChatGPT Next Web"
rg -i "ChatGPT Next Web" --type-not=git
# Check manifest files for branding
find . -type f -name "manifest*.json" -o -name "*.webmanifest" | xargs cat
Length of output: 581 Script: #!/bin/bash
# Search for "ChatGPT" to see all branding references
rg "ChatGPT" --type=html --type=tsx --type=ts --type=json -l
# Check package.json for any branding references
cat package.json | jq '.name, .description'
# Check for title tags in HTML/TSX files
ast-grep --pattern 'title="$_"'
Length of output: 192 |
||
description: "Your personal ChatGPT Chat Bot.", | ||
appleWebApp: { | ||
title: "ChatGPT Next Web", | ||
title: "ChatGPT", | ||
statusBarStyle: "default", | ||
}, | ||
themeColor: "#fafafa", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,8 @@ import { SubmitKey } from "../store/config"; | |
const cn = { | ||
WIP: "该功能仍在开发中……", | ||
Error: { | ||
Unauthorized: "现在是未授权状态,请点击左下角设置按钮输入访问密码。", | ||
Unauthorized: | ||
"现在是未授权状态,扫码关注获取免费授权码,请点击左下角设置按钮输入访问密码。", | ||
Comment on lines
+6
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification QR code scanning feature is not implemented and should be removed from the message Based on the codebase analysis:
The unauthorized message should be updated to match the actual implementation, which only requires entering an access code in the settings page, similar to the English version: "Unauthorized access, please enter access code in settings page." 🔗 Analysis chainVerify QR code feature implementation and security The error message now includes instructions to scan a QR code for obtaining a free authorization code. This change raises several concerns:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for QR code and authorization related implementations
# Search for QR code related components
rg -l "QRCode|qr-code|qrcode" --type=tsx --type=ts
# Search for authorization code handling
rg -l "authorization.*code|auth.*code" --type=tsx --type=ts
Length of output: 170 Script: #!/bin/bash
# Search for QR code related components without file type restrictions
rg -l "QRCode|qr-code|qrcode"
# Search for authorization code handling
rg -l "authorization.*code|auth.*code"
# Search for any files containing "scan" related to authorization
rg -l "scan.*code|scan.*auth"
# Look for password or access code related functionality
rg -l "access.*password|access.*code"
Length of output: 270 Script: #!/bin/bash
# Check content of relevant files to understand the access code implementation
cat app/store/access.ts
# Check the access code related strings in localization
cat app/locales/en.ts
# Check documentation about access code functionality
cat docs/faq-cn.md
Length of output: 12360 |
||
}, | ||
ChatItem: { | ||
ChatItemCount: (count: number) => `${count} 条对话`, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"name": "ChatGPT Next Web", | ||
"name": "ChatGPT", | ||
"short_name": "ChatGPT", | ||
"icons": [ | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Documentation changes may be too minimal.
While simplifying the branding is consistent with the overall changes, the new introduction "ChatGPT 。" is extremely minimal and might not provide sufficient context for new users.
Consider a balanced approach:
📝 Committable suggestion