Nullability and code coverage... we'll see how it goes.

.github/workflows/publish.yml

@@ -32,7 +32,59 @@ jobs:
         useConfigFile: true
 
     - name: Run Tests
-      run: dotnet test
+      run: dotnet test --logger trx --collect:"XPlat Code Coverage"
+
+    - name: Combine Coverage Reports # This is because one report is produced per project, and we want one result for all of them.
+      uses: danielpalme/[email protected]
+      with:
+        reports: "**/*.cobertura.xml" # REQUIRED # The coverage reports that should be parsed (separated by semicolon). Globbing is supported.
+        targetdir: "${{ github.workspace }}" # REQUIRED # The directory where the generated report should be saved.
+        reporttypes: "Cobertura" # The output formats and scope (separated by semicolon) Values: Badges, Clover, Cobertura, CsvSummary, Html, Html_Dark, Html_Light, Html_BlueRed, HtmlChart, HtmlInline, HtmlInline_AzurePipelines, HtmlInline_AzurePipelines_Dark, HtmlInline_AzurePipelines_Light, HtmlSummary, JsonSummary, Latex, LatexSummary, lcov, MarkdownSummary, MarkdownSummaryGithub, MarkdownDeltaSummary, MHtml, PngChart, SonarQube, TeamCitySummary, TextSummary, TextDeltaSummary, Xml, XmlSummary
+        verbosity: "Info" # The verbosity level of the log messages. Values: Verbose, Info, Warning, Error, Off
+        title: "Code Coverage" # Optional title.
+        tag: "${{ github.run_number }}_${{ github.run_id }}" # Optional tag or build version.
+        customSettings: "" # Optional custom settings (separated by semicolon). See: https://github.com/danielpalme/ReportGenerator/wiki/Settings.
+        toolpath: "reportgeneratortool" # Default directory for installing the dotnet tool.
+
+    - name: Upload Combined Coverage XML
+      uses: actions/upload-artifact@v4
+      with:
+        name: coverage
+        path: ${{ github.workspace }}/Cobertura.xml
+        retention-days: 5
+
+    - name: Publish Code Coverage Report
+      uses: irongut/[email protected]
+      with:
+        filename: "Cobertura.xml"
+        badge: true
+        fail_below_min: false # just informative for now
+        format: markdown
+        hide_branch_rate: false
+        hide_complexity: false
+        indicators: true
+        output: both
+        thresholds: "10 30"
+
+    - name: Add Coverage PR Comment
+      uses: marocchino/sticky-pull-request-comment@v2
+      if: github.event_name == 'pull_request'
+      with:
+        recreate: true
+        path: code-coverage-results.md
+
+    - name: Upload Test Result Files
+      uses: actions/upload-artifact@v4
+      with:
+        name: test-results
+        path: ${{ github.workspace }}/**/TestResults/**/*
+        retention-days: 5
+
+    - name: Publish Test Results
+      uses: EnricoMi/[email protected]
+      if: always()
+      with:
+        trx_files: "${{ github.workspace }}/**/*.trx" 
 
     - name: Pack
       run: dotnet pack src/Docker.Registry.DotNet -c Release -p:PackageVersion=${{ steps.gitversion.outputs.nuGetVersion }} -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg

src/Docker.Registry.DotNet/Application/Authentication/AnonymousOAuthAuthenticationProvider.cs

@@ -49,6 +49,11 @@ public override async Task Authenticate(
             bearerBits.Service,
             bearerBits.Scope);
 
+        if (token?.Token == null)
+        {
+            throw new ArgumentNullException(nameof(token.Token), "Authorization token cannot be null");
+        }
+
         //Set the header
         request.Headers.Authorization = new AuthenticationHeaderValue(Schema, token.Token);
     }

src/Docker.Registry.DotNet/Application/Authentication/AuthenticateParser.cs

@@ -17,7 +17,7 @@ namespace Docker.Registry.DotNet.Application.Authentication;
 
 internal static class AuthenticateParser
 {
-    public static IDictionary<string, string> Parse(string value)
+    public static IDictionary<string, string?> Parse(string value)
     {
         //https://stackoverflow.com/questions/45516717/extracting-and-parsing-the-www-authenticate-header-from-httpresponsemessage-in/45516809#45516809            
         return SplitWWWAuthenticateHeader(value).ToDictionary(GetKey, GetValue);
@@ -27,9 +27,9 @@ private static IEnumerable<string> SplitWWWAuthenticateHeader(string value)
     {
         var builder = new StringBuilder();
         var inQuotes = false;
-        for (var i = 0; i < value.Length; i++)
+
+        foreach (var charI in value)
         {
-            var charI = value[i];
             switch (charI)
             {
                 case '\"':

src/Docker.Registry.DotNet/Application/Authentication/ParsedAuthentication.cs

@@ -15,11 +15,11 @@
 
 namespace Docker.Registry.DotNet.Application.Authentication;
 
-internal class ParsedAuthentication(string realm, string service, string scope)
+internal class ParsedAuthentication(string? realm, string? service, string? scope)
 {
-    public string Realm { get; } = realm;
+    public string? Realm { get; } = realm;
 
-    public string Service { get; } = service;
+    public string? Service { get; } = service;
 
-    public string Scope { get; } = scope;
+    public string? Scope { get; } = scope;
 }

src/Docker.Registry.DotNet/Application/Authentication/PasswordOAuthAuthenticationProvider.cs

@@ -59,6 +59,11 @@ public override async Task Authenticate(
             scope,
             username,
             password);
+
+        if (token?.AccessToken == null)
+        {
+            throw new ArgumentNullException(nameof(token.AccessToken), "Authorization token cannot be null");
+        }
 
         //Set the header
         request.Headers.Authorization =

src/Docker.Registry.DotNet/Application/OAuth/OAuthClient.cs

@@ -22,7 +22,7 @@ internal class OAuthClient
     private static readonly HttpClient _client = new();
 
     private async Task<OAuthToken?> GetTokenInner(
-        string realm,
+        string? realm,
         string? service,
         string? scope,
         string? username,
@@ -52,7 +52,7 @@ internal class OAuthClient
             request = new HttpRequestMessage(HttpMethod.Post, realm)
             {
                 Content = new FormUrlEncodedContent(
-                    new Dictionary<string, string>
+                    new Dictionary<string, string?>
                     {
                         { "client_id", "Docker.Registry.DotNet" },
                         { "grant_type", "password" },
@@ -94,17 +94,17 @@ internal class OAuthClient
     }
 
     public Task<OAuthToken?> GetToken(
-        string realm,
-        string service,
-        string scope,
+        string? realm,
+        string? service,
+        string? scope,
         CancellationToken cancellationToken = default)
     {
         return this.GetTokenInner(realm, service, scope, null, null, cancellationToken);
     }
 
     public Task<OAuthToken?> GetToken(
-        string realm,
-        string service,
+        string? realm,
+        string? service,
         string? scope,
         string username,
         string password,

src/Docker.Registry.DotNet/Domain/Manifests/GetImageManifestResult.cs

@@ -19,14 +19,14 @@ public class GetImageManifestResult
 {
     internal GetImageManifestResult(string mediaType, ImageManifest manifest, string content)
     {
-            this.Manifest = manifest;
-            this.Content = content;
-            this.MediaType = mediaType;
-        }
+        this.Manifest = manifest;
+        this.Content = content;
+        this.MediaType = mediaType;
+    }
 
-    public string DockerContentDigest { get; internal set; }
+    public string? DockerContentDigest { get; internal set; }
 
-    public string Etag { get; internal set; }
+    public string? Etag { get; internal set; }
 
     public string MediaType { get; }
 

src/Docker.Registry.DotNet/Domain/Registry/RegistryApiException.cs

@@ -53,5 +53,5 @@ internal RegistryApiException(RegistryApiResponse<TBody> response)
         Body = response.Body;
     }
 
-    public TBody Body { get; }
+    public TBody? Body { get; }
 }

src/Docker.Registry.DotNet/Domain/Repository/ListRepositoryTagsResponse.cs

@@ -6,11 +6,11 @@ public class ListRepositoryTagsResponse
     public int Count { get; set; }
 
     [JsonProperty("next")]
-    public string Next { get; set; }
+    public string? Next { get; set; }
 
     [JsonProperty("previous")]
-    public string Previous { get; set; }
+    public string? Previous { get; set; }
 
     [JsonProperty("results")]
-    public List<RepositoryTag> Tags { get; set; }
+    public List<RepositoryTag>? Tags { get; set; }
 }

src/Docker.Registry.DotNet/Infrastructure/Helpers/DictionaryExtensions.cs

@@ -28,13 +28,10 @@ public static string GetQueryString(this IDictionary<string, string[]> values)
                         v => $"{Uri.EscapeUriString(pair.Key)}={Uri.EscapeDataString(v)}"))));
     }
 
-    public static TValue GetValueOrDefault<TKey, TValue>(
+    public static TValue? GetValueOrDefault<TKey, TValue>(
         this IDictionary<TKey, TValue> dict,
         TKey key)
     {
-        if (dict.TryGetValue(key, out var value))
-            return value;
-
-        return default;
+        return dict.TryGetValue(key, out var value) ? value : default;
     }
 }