Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor (v4.0) #376

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Refactor (v4.0) #376

wants to merge 18 commits into from

Conversation

ChanceSD
Copy link
Owner

@ChanceSD ChanceSD commented Apr 7, 2023 •
edited
Loading

This is essentially almost a full recode of the plugin.
Any plugins currently hooking into PvPManager will break due to the package changes.
Performance should be slightly better and with more features, hopefully clearing most of the current suggestions.
Should also make the code easier to work on for future updates.

Dev build here: https://ci.codemc.io/job/ChanceSD/job/PvPManager-v4/
Use at your own risk, will probably reset your config/messages

@ChanceSD ChanceSD force-pushed the master branch 2 times, most recently from 83c9581 to 7a5ba65 Compare April 19, 2023 04:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

41.3% 41.3% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 29 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 27 Code Smells

42.8% 42.8% Coverage
0.0% 0.0% Duplication

@ChanceSD ChanceSD force-pushed the master-refactor branch 2 times, most recently from cd4056c to 4f99618 Compare October 27, 2023 15:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

43.2% 43.2% Coverage
0.0% 0.0% Duplication

@ChanceSD ChanceSD changed the title Refactor Refactor (v4.0) Feb 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

24 New issues
0 Security Hotspots
43.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChanceSD ChanceSD added this to the v4.0 milestone Feb 8, 2024
@ChanceSD ChanceSD marked this pull request as draft February 22, 2024 04:42
@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Mar 26, 2024 •
edited
Loading

Here's the code health analysis summary for commits abaf570..c704a68. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava❌ Failure
❗ 31 occurences introduced
🎯 49 occurences resolved
View Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
26 New issues
0 Accepted issues

Measures
0 Security Hotspots
43.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChanceSD ChanceSD force-pushed the master branch 2 times, most recently from 5ad90b8 to c4d3988 Compare March 31, 2024 10:06
@ChanceSD ChanceSD force-pushed the master-refactor branch 6 times, most recently from 69e9813 to b506162 Compare April 30, 2024 19:36
@ChanceSD ChanceSD self-assigned this May 3, 2024
@ChanceSD ChanceSD force-pushed the master-refactor branch 2 times, most recently from 00c9449 to 884af2f Compare July 20, 2024 20:57
@ChanceSD ChanceSD mentioned this pull request Jul 27, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@ChanceSD ChanceSD force-pushed the master branch 2 times, most recently from 707453b to deec3e3 Compare December 29, 2024 19:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
29.5% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChanceSD ChanceSD

Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ChanceSD