-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Research Impacts admin page #443
Conversation
@@ -0,0 +1,305 @@ | |||
from difflib import SequenceMatcher | |||
from django.contrib.auth.models import User |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'django.contrib.auth.models.User' imported but unused
from django.contrib.auth.models import User | ||
from chameleon.models import PIEligibility | ||
from projects.models import Project, Publication, Tag | ||
from datetime import datetime, timedelta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'datetime.timedelta' imported but unused
from projects.models import Project, Publication, Tag | ||
from datetime import datetime, timedelta | ||
from django.db.models import Sum, FloatField, Count, Q | ||
from allocations.models import Charge, Allocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[flake8] <401> reported by reviewdog 🐶
'allocations.models.Allocation' imported but unused
epscor_states = set(s for s in states if s in EPSCOR_STATES) | ||
|
||
|
||
edu_states = set() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <303> reported by reviewdog 🐶
too many blank lines (2)
edu_epscor_states = set(s for s in edu_states if s in EPSCOR_STATES) | ||
|
||
|
||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <303> reported by reviewdog 🐶
too many blank lines (2)
chameleon/research_impacts.py
Outdated
tag=computing_education_tag, | ||
).distinct() | ||
active_education_projects_per_academic_year.append( | ||
(f"Fall {year} - Spring {year+1}", ay_education_projects_with_active_allocations.count()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <226> reported by reviewdog 🐶
missing whitespace around arithmetic operator
) | ||
|
||
|
||
publications_per_year = publication_information(start_year, end_year) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <303> reported by reviewdog 🐶
too many blank lines (2)
"edu_users": len(edu_users), | ||
} | ||
|
||
def get_education_users(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1
chameleon/research_impacts.py
Outdated
return { | ||
"total": total, | ||
"gt100": gt100, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no newline at end of file
).distinct() | ||
active_education_projects_per_academic_year.append( | ||
( | ||
f"Fall {year} - Spring {year+1}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [flake8] <226> reported by reviewdog 🐶
missing whitespace around arithmetic operator
No description provided.