Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Research Impacts admin page #443

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add Research Impacts admin page #443

merged 2 commits into from
Apr 23, 2024

Conversation

Mark-Powers
Copy link
Contributor

No description provided.

@@ -0,0 +1,305 @@
from difflib import SequenceMatcher
from django.contrib.auth.models import User
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8] <401> reported by reviewdog 🐶
'django.contrib.auth.models.User' imported but unused

from django.contrib.auth.models import User
from chameleon.models import PIEligibility
from projects.models import Project, Publication, Tag
from datetime import datetime, timedelta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8] <401> reported by reviewdog 🐶
'datetime.timedelta' imported but unused

from projects.models import Project, Publication, Tag
from datetime import datetime, timedelta
from django.db.models import Sum, FloatField, Count, Q
from allocations.models import Charge, Allocation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flake8] <401> reported by reviewdog 🐶
'allocations.models.Allocation' imported but unused

epscor_states = set(s for s in states if s in EPSCOR_STATES)


edu_states = set()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <303> reported by reviewdog 🐶
too many blank lines (2)

edu_epscor_states = set(s for s in edu_states if s in EPSCOR_STATES)


return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <303> reported by reviewdog 🐶
too many blank lines (2)

tag=computing_education_tag,
).distinct()
active_education_projects_per_academic_year.append(
(f"Fall {year} - Spring {year+1}", ay_education_projects_with_active_allocations.count())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <226> reported by reviewdog 🐶
missing whitespace around arithmetic operator

)


publications_per_year = publication_information(start_year, end_year)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <303> reported by reviewdog 🐶
too many blank lines (2)

"edu_users": len(edu_users),
}

def get_education_users():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1

return {
"total": total,
"gt100": gt100,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [flake8] <292> reported by reviewdog 🐶
no newline at end of file

).distinct()
active_education_projects_per_academic_year.append(
(
f"Fall {year} - Spring {year+1}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <226> reported by reviewdog 🐶
missing whitespace around arithmetic operator

@Mark-Powers Mark-Powers merged commit 9114d43 into master Apr 23, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant