-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flavor reservation configuration #318
base: stable/2023.1
Are you sure you want to change the base?
Conversation
@msherman64 Is there a way I can assert a condition on the defaults? I want to ensure |
there's not really a way to do this within the defaults file / config file. You either need to do this in an ansible task (like in prechecks or config steps, in kolla-ansible), or via an external tool like ansible-lint. In chi-in-a-box itself, you're almost limited to the logic that jinja can do. will blazar fail if both host_reservation and flavor_reservation are enabled? |
Main issue is that our host_reservation code assumes a lot about hosts, and the monitoring fails for some reason. I'm still digging into this. |
@@ -370,3 +370,8 @@ enable_image_cleaner: no | |||
|
|||
# Manila | |||
default_share_type: cephfsnfstype | |||
|
|||
# Flavor reservation | |||
enable_host_reservation: "{{ enable_nova | bool }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it be more clear and consistent to name these labels with "blazar_", e.g. "blazar_enable_host_reservation".
This adds configuration needed for the blazar flavor plugin.