Skip to content

Commit

Permalink
hack: reduce volume of GB channels in mono
Browse files Browse the repository at this point in the history
somewhat remedies the issue regarding volume balance between the GB and GBA audio channels in Pokemon. This is a super lazy hack, and might have unintended consequences, but it seems fine by my observation.
  • Loading branch information
ChainSwordCS committed Jul 31, 2024
1 parent 4b8404c commit 6396cb6
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions arm7/source/gbsound.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,13 @@ static void calcChannelVolume(int channel, int& volumeL, int& shiftL, int& volum
volumeR = 0;
shiftR = 3;
}

// hack: reduce volume of GB channels outputting in mono
if (volumeL == volumeR)
{
volumeL >>= 1; // volumeL = volumeL / 2;
volumeR = volumeL;
}
}

static void updateChannelVolume(int channel)
Expand Down

0 comments on commit 6396cb6

Please sign in to comment.