fix: add nullable type for transaction (#248)

ChainSafe · Aug 27, 2024 · d232283 · d232283
1 parent 6fa2dbd
commit d232283
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/snap/snap.manifest.json b/packages/snap/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "git+https://github.com/chainsafe/metamask-snap-polkadot.git"
   },
   "source": {
-    "shasum": "Ub34hILBwiaKcauY0Oz3pstQ5uZidpRJlnx+mE6hXRI=",
+    "shasum": "XZTf0C/b6ZNF2fpguQYHO282nTPg9irWFoamJ4aUSn4=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

diff --git a/packages/snap/src/util/validation.ts b/packages/snap/src/util/validation.ts
@@ -2,6 +2,7 @@ import type { BlockId } from '@chainsafe/metamask-polkadot-types';
 import type { SignerPayloadRaw } from '@polkadot/types/types';
 import type { Describe, Infer } from 'superstruct';
 import {
+  nullable,
   array,
   boolean,
   define,
@@ -22,21 +23,21 @@ const HexStringStruct = define<`0x${string}`>('HexString', (value) => {
 // SignerPayloadJSON from '@polkadot/types/types';
 const SignaturePayloadJSONSchema = object({
   address: string(),
-  assetId: optional(union([number(), object()])),
+  assetId: nullable(optional(union([number(), object()]))),
   blockHash: HexStringStruct,
   blockNumber: HexStringStruct,
   era: HexStringStruct,
   genesisHash: HexStringStruct,
-  metadataHash: optional(HexStringStruct),
+  metadataHash: nullable(optional(HexStringStruct)),
   method: string(),
-  mode: optional(number()),
+  mode: nullable(optional(number())),
   nonce: HexStringStruct,
   specVersion: HexStringStruct,
   tip: HexStringStruct,
   transactionVersion: HexStringStruct,
   signedExtensions: array(string()),
   version: number(),
-  withSignedTransaction: optional(boolean())
+  withSignedTransaction: nullable(optional(boolean()))
 });
 
 type SignaturePayloadJSONType = Infer<typeof SignaturePayloadJSONSchema>;