Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip useWorker mode for gossipsub e2e tests #6368

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: skip useWorker mode for gossipsub e2e tests #6368

merged 1 commit into from
Jan 30, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jan 29, 2024

Motivation

I see a lot of failed gossipsub e2e tests since we switched to vitest, and it always happen with useWorker=true

Description

Skipping tests with useWorker=true in CI, while we leave that for local tests if we find any issues with it in the future

  • Given vitest also runs in worker thread, it caused the test to be unstable in CI environment
  • Gossipsub logic does not really depend on this useWorker flag

cc @wemeetagain

part of #6358

@twoeths twoeths requested a review from a team as a code owner January 29, 2024 07:31
@twoeths twoeths mentioned this pull request Jan 29, 2024
Open
14 tasks
@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: a7c5692 Previous: 6adbd27 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 864.25 us/op 878.16 us/op 0.98
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 93.529 us/op 83.254 us/op 1.12
BLS verify - blst-native 1.3789 ms/op 1.3080 ms/op 1.05
BLS verifyMultipleSignatures 3 - blst-native 2.8707 ms/op 2.7450 ms/op 1.05
BLS verifyMultipleSignatures 8 - blst-native 6.3115 ms/op 6.0248 ms/op 1.05
BLS verifyMultipleSignatures 32 - blst-native 23.066 ms/op 22.013 ms/op 1.05
BLS verifyMultipleSignatures 64 - blst-native 45.604 ms/op 43.351 ms/op 1.05
BLS verifyMultipleSignatures 128 - blst-native 90.234 ms/op 86.605 ms/op 1.04
BLS deserializing 10000 signatures 956.04 ms/op 935.39 ms/op 1.02
BLS deserializing 100000 signatures 9.3205 s/op 9.4435 s/op 0.99
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3178 ms/op 1.3309 ms/op 0.99
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4828 ms/op 1.5029 ms/op 0.99
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.7538 ms/op 2.9938 ms/op 0.92
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.2184 ms/op 4.7075 ms/op 0.90
BLS verifyMultipleSignatures - same message - 128 - blst-native 7.3484 ms/op 5.6641 ms/op 1.30
BLS aggregatePubkeys 32 - blst-native 27.278 us/op 26.005 us/op 1.05
BLS aggregatePubkeys 128 - blst-native 98.054 us/op 101.67 us/op 0.96
getAttestationsForBlock 41.722 ms/op 44.473 ms/op 0.94
getSlashingsAndExits - default max 166.47 us/op 172.50 us/op 0.97
getSlashingsAndExits - 2k 385.20 us/op 378.69 us/op 1.02
proposeBlockBody type=full, size=empty 5.0935 ms/op 6.0230 ms/op 0.85
isKnown best case - 1 super set check 312.00 ns/op 312.00 ns/op 1.00
isKnown normal case - 2 super set checks 289.00 ns/op 300.00 ns/op 0.96
isKnown worse case - 16 super set checks 289.00 ns/op 297.00 ns/op 0.97
CheckpointStateCache - add get delete 4.8050 us/op 5.4400 us/op 0.88
validate api signedAggregateAndProof - struct 2.6909 ms/op 2.9528 ms/op 0.91
validate gossip signedAggregateAndProof - struct 2.6928 ms/op 2.9471 ms/op 0.91
validate gossip attestation - vc 640000 1.3331 ms/op 1.4288 ms/op 0.93
batch validate gossip attestation - vc 640000 - chunk 32 162.76 us/op 164.01 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 64 143.18 us/op 144.18 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 128 132.30 us/op 133.63 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 256 134.43 us/op 135.35 us/op 0.99
pickEth1Vote - no votes 1.2328 ms/op 1.2393 ms/op 0.99
pickEth1Vote - max votes 9.1500 ms/op 9.8853 ms/op 0.93
pickEth1Vote - Eth1Data hashTreeRoot value x2048 19.807 ms/op 19.197 ms/op 1.03
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.011 ms/op 25.707 ms/op 0.86
pickEth1Vote - Eth1Data fastSerialize value x2048 633.71 us/op 610.02 us/op 1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.4455 ms/op 7.0936 ms/op 0.63
bytes32 toHexString 490.00 ns/op 530.00 ns/op 0.92
bytes32 Buffer.toString(hex) 289.00 ns/op 306.00 ns/op 0.94
bytes32 Buffer.toString(hex) from Uint8Array 434.00 ns/op 437.00 ns/op 0.99
bytes32 Buffer.toString(hex) + 0x 294.00 ns/op 310.00 ns/op 0.95
Object access 1 prop 0.16200 ns/op 0.16600 ns/op 0.98
Map access 1 prop 0.14900 ns/op 0.15900 ns/op 0.94
Object get x1000 7.7470 ns/op 8.2490 ns/op 0.94
Map get x1000 0.77600 ns/op 0.78600 ns/op 0.99
Object set x1000 50.789 ns/op 51.600 ns/op 0.98
Map set x1000 40.656 ns/op 40.171 ns/op 1.01
Return object 10000 times 0.24360 ns/op 0.23890 ns/op 1.02
Throw Error 10000 times 3.9151 us/op 3.9547 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 3.3230 us/op 3.4140 us/op 0.97
fastMsgIdFn h32 xxhash / 200 bytes 286.00 ns/op 297.00 ns/op 0.96
fastMsgIdFn h64 xxhash / 200 bytes 347.00 ns/op 355.00 ns/op 0.98
fastMsgIdFn sha256 / 1000 bytes 11.566 us/op 11.884 us/op 0.97
fastMsgIdFn h32 xxhash / 1000 bytes 413.00 ns/op 432.00 ns/op 0.96
fastMsgIdFn h64 xxhash / 1000 bytes 420.00 ns/op 440.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 105.81 us/op 109.11 us/op 0.97
fastMsgIdFn h32 xxhash / 10000 bytes 1.9880 us/op 1.9330 us/op 1.03
fastMsgIdFn h64 xxhash / 10000 bytes 1.3650 us/op 1.3310 us/op 1.03
send data - 1000 256B messages 18.175 ms/op 19.923 ms/op 0.91
send data - 1000 512B messages 23.881 ms/op 27.585 ms/op 0.87
send data - 1000 1024B messages 41.432 ms/op 43.567 ms/op 0.95
send data - 1000 1200B messages 36.557 ms/op 40.588 ms/op 0.90
send data - 1000 2048B messages 46.750 ms/op 50.858 ms/op 0.92
send data - 1000 4096B messages 44.424 ms/op 45.578 ms/op 0.97
send data - 1000 16384B messages 112.03 ms/op 121.66 ms/op 0.92
send data - 1000 65536B messages 492.58 ms/op 574.28 ms/op 0.86
enrSubnets - fastDeserialize 64 bits 1.2650 us/op 1.3220 us/op 0.96
enrSubnets - ssz BitVector 64 bits 431.00 ns/op 425.00 ns/op 1.01
enrSubnets - fastDeserialize 4 bits 173.00 ns/op 172.00 ns/op 1.01
enrSubnets - ssz BitVector 4 bits 441.00 ns/op 430.00 ns/op 1.03
prioritizePeers score -10:0 att 32-0.1 sync 2-0 109.37 us/op 104.98 us/op 1.04
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 131.50 us/op 130.94 us/op 1.00
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 173.48 us/op 167.42 us/op 1.04
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 305.66 us/op 298.24 us/op 1.02
prioritizePeers score 0:0 att 64-1 sync 4-1 373.60 us/op 355.18 us/op 1.05
array of 16000 items push then shift 1.6365 us/op 1.6358 us/op 1.00
LinkedList of 16000 items push then shift 9.0690 ns/op 9.2780 ns/op 0.98
array of 16000 items push then pop 103.30 ns/op 78.620 ns/op 1.31
LinkedList of 16000 items push then pop 8.7190 ns/op 8.8940 ns/op 0.98
array of 24000 items push then shift 2.5011 us/op 2.3994 us/op 1.04
LinkedList of 24000 items push then shift 9.0390 ns/op 9.0110 ns/op 1.00
array of 24000 items push then pop 142.50 ns/op 103.48 ns/op 1.38
LinkedList of 24000 items push then pop 8.6700 ns/op 9.3180 ns/op 0.93
intersect bitArray bitLen 8 6.4050 ns/op 7.0040 ns/op 0.91
intersect array and set length 8 64.569 ns/op 66.413 ns/op 0.97
intersect bitArray bitLen 128 33.922 ns/op 37.320 ns/op 0.91
intersect array and set length 128 885.63 ns/op 918.25 ns/op 0.96
bitArray.getTrueBitIndexes() bitLen 128 1.6350 us/op 1.5720 us/op 1.04
bitArray.getTrueBitIndexes() bitLen 248 2.7810 us/op 2.5570 us/op 1.09
bitArray.getTrueBitIndexes() bitLen 512 5.5050 us/op 4.9760 us/op 1.11
Buffer.concat 32 items 991.00 ns/op 1.0490 us/op 0.94
Uint8Array.set 32 items 2.1520 us/op 2.0010 us/op 1.08
Set add up to 64 items then delete first 4.5801 us/op 4.4192 us/op 1.04
OrderedSet add up to 64 items then delete first 5.7438 us/op 5.6639 us/op 1.01
Set add up to 64 items then delete last 4.9601 us/op 4.8273 us/op 1.03
OrderedSet add up to 64 items then delete last 6.0896 us/op 6.0377 us/op 1.01
Set add up to 64 items then delete middle 4.7397 us/op 4.7841 us/op 0.99
OrderedSet add up to 64 items then delete middle 7.2582 us/op 7.4237 us/op 0.98
Set add up to 128 items then delete first 9.5334 us/op 9.6600 us/op 0.99
OrderedSet add up to 128 items then delete first 12.977 us/op 12.773 us/op 1.02
Set add up to 128 items then delete last 9.6065 us/op 9.5134 us/op 1.01
OrderedSet add up to 128 items then delete last 11.778 us/op 12.143 us/op 0.97
Set add up to 128 items then delete middle 9.6686 us/op 9.5494 us/op 1.01
OrderedSet add up to 128 items then delete middle 18.037 us/op 18.053 us/op 1.00
Set add up to 256 items then delete first 20.197 us/op 19.338 us/op 1.04
OrderedSet add up to 256 items then delete first 27.321 us/op 26.217 us/op 1.04
Set add up to 256 items then delete last 18.995 us/op 18.805 us/op 1.01
OrderedSet add up to 256 items then delete last 24.505 us/op 24.170 us/op 1.01
Set add up to 256 items then delete middle 19.080 us/op 18.901 us/op 1.01
OrderedSet add up to 256 items then delete middle 48.970 us/op 47.923 us/op 1.02
transfer serialized Status (84 B) 1.8250 us/op 1.7620 us/op 1.04
copy serialized Status (84 B) 1.2560 us/op 1.2770 us/op 0.98
transfer serialized SignedVoluntaryExit (112 B) 1.8880 us/op 1.8600 us/op 1.02
copy serialized SignedVoluntaryExit (112 B) 1.5390 us/op 1.3900 us/op 1.11
transfer serialized ProposerSlashing (416 B) 3.2840 us/op 2.3750 us/op 1.38
copy serialized ProposerSlashing (416 B) 2.8500 us/op 2.2050 us/op 1.29
transfer serialized Attestation (485 B) 3.3540 us/op 2.3980 us/op 1.40
copy serialized Attestation (485 B) 2.9000 us/op 2.0450 us/op 1.42
transfer serialized AttesterSlashing (33232 B) 3.0670 us/op 2.6180 us/op 1.17
copy serialized AttesterSlashing (33232 B) 5.2970 us/op 5.5440 us/op 0.96
transfer serialized Small SignedBeaconBlock (128000 B) 2.6890 us/op 2.9580 us/op 0.91
copy serialized Small SignedBeaconBlock (128000 B) 14.480 us/op 13.642 us/op 1.06
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1430 us/op 2.9110 us/op 1.08
copy serialized Avg SignedBeaconBlock (200000 B) 20.868 us/op 21.188 us/op 0.98
transfer serialized BlobsSidecar (524380 B) 2.9780 us/op 3.0900 us/op 0.96
copy serialized BlobsSidecar (524380 B) 92.762 us/op 92.866 us/op 1.00
transfer serialized Big SignedBeaconBlock (1000000 B) 3.2020 us/op 3.0200 us/op 1.06
copy serialized Big SignedBeaconBlock (1000000 B) 170.82 us/op 184.15 us/op 0.93
pass gossip attestations to forkchoice per slot 4.3118 ms/op 3.9770 ms/op 1.08
forkChoice updateHead vc 100000 bc 64 eq 0 700.19 us/op 710.17 us/op 0.99
forkChoice updateHead vc 600000 bc 64 eq 0 4.2271 ms/op 4.2355 ms/op 1.00
forkChoice updateHead vc 1000000 bc 64 eq 0 7.1212 ms/op 7.1898 ms/op 0.99
forkChoice updateHead vc 600000 bc 320 eq 0 4.2268 ms/op 4.6607 ms/op 0.91
forkChoice updateHead vc 600000 bc 1200 eq 0 4.3108 ms/op 4.5316 ms/op 0.95
forkChoice updateHead vc 600000 bc 7200 eq 0 5.3341 ms/op 5.5304 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 1000 11.333 ms/op 11.529 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 10000 12.030 ms/op 12.352 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 300000 16.482 ms/op 16.453 ms/op 1.00
computeDeltas 500000 validators 300 proto nodes 6.7170 ms/op 6.7701 ms/op 0.99
computeDeltas 500000 validators 1200 proto nodes 6.5954 ms/op 6.8822 ms/op 0.96
computeDeltas 500000 validators 7200 proto nodes 6.2799 ms/op 6.8238 ms/op 0.92
computeDeltas 750000 validators 300 proto nodes 9.7032 ms/op 10.244 ms/op 0.95
computeDeltas 750000 validators 1200 proto nodes 9.5842 ms/op 10.287 ms/op 0.93
computeDeltas 750000 validators 7200 proto nodes 9.7448 ms/op 10.215 ms/op 0.95
computeDeltas 1400000 validators 300 proto nodes 18.158 ms/op 20.270 ms/op 0.90
computeDeltas 1400000 validators 1200 proto nodes 18.978 ms/op 19.965 ms/op 0.95
computeDeltas 1400000 validators 7200 proto nodes 18.706 ms/op 20.593 ms/op 0.91
computeDeltas 2100000 validators 300 proto nodes 27.661 ms/op 30.796 ms/op 0.90
computeDeltas 2100000 validators 1200 proto nodes 27.628 ms/op 31.612 ms/op 0.87
computeDeltas 2100000 validators 7200 proto nodes 27.146 ms/op 32.335 ms/op 0.84
altair processAttestation - 250000 vs - 7PWei normalcase 2.2145 ms/op 2.2035 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei worstcase 3.2768 ms/op 3.2616 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 177.90 us/op 184.26 us/op 0.97
altair processAttestation - setStatus - 1/3 committees join 343.32 us/op 356.82 us/op 0.96
altair processAttestation - setStatus - 1/2 committees join 464.15 us/op 480.41 us/op 0.97
altair processAttestation - setStatus - 2/3 committees join 580.45 us/op 659.44 us/op 0.88
altair processAttestation - setStatus - 4/5 committees join 783.98 us/op 926.79 us/op 0.85
altair processAttestation - setStatus - 100% committees join 905.62 us/op 940.48 us/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 9.4568 ms/op 10.354 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 37.074 ms/op 36.345 ms/op 1.02
altair processBlock - 250000 vs - 7PWei worstcase 40.144 ms/op 46.172 ms/op 0.87
altair processBlock - 250000 vs - 7PWei worstcase hashState 88.721 ms/op 97.346 ms/op 0.91
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3605 ms/op 2.5078 ms/op 0.94
phase0 processBlock - 250000 vs - 7PWei worstcase 28.580 ms/op 29.565 ms/op 0.97
altair processEth1Data - 250000 vs - 7PWei normalcase 489.69 us/op 595.05 us/op 0.82
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 10.229 us/op 9.8350 us/op 1.04
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 53.265 us/op 56.910 us/op 0.94
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 17.896 us/op 15.160 us/op 1.18
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.9790 us/op 7.0760 us/op 1.41
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 170.72 us/op 160.57 us/op 1.06
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0808 ms/op 1.0653 ms/op 1.01
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.8961 ms/op 1.4848 ms/op 1.28
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5828 ms/op 1.4638 ms/op 1.08
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.1163 ms/op 3.9414 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.3202 ms/op 2.5026 ms/op 0.93
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.2897 ms/op 5.1831 ms/op 1.02
Tree 40 250000 create 363.99 ms/op 358.23 ms/op 1.02
Tree 40 250000 get(125000) 204.96 ns/op 210.69 ns/op 0.97
Tree 40 250000 set(125000) 968.08 ns/op 1.0272 us/op 0.94
Tree 40 250000 toArray() 18.719 ms/op 18.451 ms/op 1.01
Tree 40 250000 iterate all - toArray() + loop 18.568 ms/op 18.580 ms/op 1.00
Tree 40 250000 iterate all - get(i) 67.149 ms/op 66.137 ms/op 1.02
MutableVector 250000 create 11.091 ms/op 14.343 ms/op 0.77
MutableVector 250000 get(125000) 6.5200 ns/op 6.6820 ns/op 0.98
MutableVector 250000 set(125000) 274.85 ns/op 272.90 ns/op 1.01
MutableVector 250000 toArray() 3.2486 ms/op 3.2440 ms/op 1.00
MutableVector 250000 iterate all - toArray() + loop 3.9192 ms/op 3.5392 ms/op 1.11
MutableVector 250000 iterate all - get(i) 1.5634 ms/op 1.5922 ms/op 0.98
Array 250000 create 2.8097 ms/op 2.8882 ms/op 0.97
Array 250000 clone - spread 1.1996 ms/op 1.4446 ms/op 0.83
Array 250000 get(125000) 1.0080 ns/op 1.2660 ns/op 0.80
Array 250000 set(125000) 4.0720 ns/op 4.6000 ns/op 0.89
Array 250000 iterate all - loop 164.15 us/op 193.91 us/op 0.85
effectiveBalanceIncrements clone Uint8Array 300000 26.258 us/op 31.810 us/op 0.83
effectiveBalanceIncrements clone MutableVector 300000 338.00 ns/op 467.00 ns/op 0.72
effectiveBalanceIncrements rw all Uint8Array 300000 201.31 us/op 236.87 us/op 0.85
effectiveBalanceIncrements rw all MutableVector 300000 82.276 ms/op 96.629 ms/op 0.85
phase0 afterProcessEpoch - 250000 vs - 7PWei 111.69 ms/op 128.43 ms/op 0.87
phase0 beforeProcessEpoch - 250000 vs - 7PWei 51.451 ms/op 53.022 ms/op 0.97
altair processEpoch - mainnet_e81889 511.09 ms/op 518.76 ms/op 0.99
mainnet_e81889 - altair beforeProcessEpoch 82.321 ms/op 84.593 ms/op 0.97
mainnet_e81889 - altair processJustificationAndFinalization 14.291 us/op 15.683 us/op 0.91
mainnet_e81889 - altair processInactivityUpdates 5.8331 ms/op 6.1318 ms/op 0.95
mainnet_e81889 - altair processRewardsAndPenalties 60.845 ms/op 62.464 ms/op 0.97
mainnet_e81889 - altair processRegistryUpdates 2.4770 us/op 2.6340 us/op 0.94
mainnet_e81889 - altair processSlashings 491.00 ns/op 471.00 ns/op 1.04
mainnet_e81889 - altair processEth1DataReset 666.00 ns/op 532.00 ns/op 1.25
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9726 ms/op 1.3789 ms/op 1.43
mainnet_e81889 - altair processSlashingsReset 5.1010 us/op 3.6460 us/op 1.40
mainnet_e81889 - altair processRandaoMixesReset 4.9410 us/op 4.1450 us/op 1.19
mainnet_e81889 - altair processHistoricalRootsUpdate 602.00 ns/op 1.0360 us/op 0.58
mainnet_e81889 - altair processParticipationFlagUpdates 1.7010 us/op 1.8650 us/op 0.91
mainnet_e81889 - altair processSyncCommitteeUpdates 394.00 ns/op 617.00 ns/op 0.64
mainnet_e81889 - altair afterProcessEpoch 115.95 ms/op 129.63 ms/op 0.89
capella processEpoch - mainnet_e217614 2.1193 s/op 2.2383 s/op 0.95
mainnet_e217614 - capella beforeProcessEpoch 516.03 ms/op 494.08 ms/op 1.04
mainnet_e217614 - capella processJustificationAndFinalization 23.152 us/op 15.070 us/op 1.54
mainnet_e217614 - capella processInactivityUpdates 21.173 ms/op 20.067 ms/op 1.06
mainnet_e217614 - capella processRewardsAndPenalties 415.39 ms/op 422.29 ms/op 0.98
mainnet_e217614 - capella processRegistryUpdates 18.484 us/op 19.229 us/op 0.96
mainnet_e217614 - capella processSlashings 542.00 ns/op 585.00 ns/op 0.93
mainnet_e217614 - capella processEth1DataReset 406.00 ns/op 468.00 ns/op 0.87
mainnet_e217614 - capella processEffectiveBalanceUpdates 5.6762 ms/op 4.7763 ms/op 1.19
mainnet_e217614 - capella processSlashingsReset 3.5190 us/op 3.7200 us/op 0.95
mainnet_e217614 - capella processRandaoMixesReset 6.4020 us/op 4.7700 us/op 1.34
mainnet_e217614 - capella processHistoricalRootsUpdate 680.00 ns/op 663.00 ns/op 1.03
mainnet_e217614 - capella processParticipationFlagUpdates 1.3770 us/op 1.9050 us/op 0.72
mainnet_e217614 - capella afterProcessEpoch 303.66 ms/op 323.34 ms/op 0.94
phase0 processEpoch - mainnet_e58758 437.85 ms/op 459.94 ms/op 0.95
mainnet_e58758 - phase0 beforeProcessEpoch 119.60 ms/op 147.77 ms/op 0.81
mainnet_e58758 - phase0 processJustificationAndFinalization 16.247 us/op 15.366 us/op 1.06
mainnet_e58758 - phase0 processRewardsAndPenalties 63.804 ms/op 53.852 ms/op 1.18
mainnet_e58758 - phase0 processRegistryUpdates 10.016 us/op 9.1680 us/op 1.09
mainnet_e58758 - phase0 processSlashings 414.00 ns/op 623.00 ns/op 0.66
mainnet_e58758 - phase0 processEth1DataReset 381.00 ns/op 448.00 ns/op 0.85
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1060 ms/op 1.1288 ms/op 0.98
mainnet_e58758 - phase0 processSlashingsReset 3.0540 us/op 2.7130 us/op 1.13
mainnet_e58758 - phase0 processRandaoMixesReset 4.1230 us/op 4.1010 us/op 1.01
mainnet_e58758 - phase0 processHistoricalRootsUpdate 386.00 ns/op 432.00 ns/op 0.89
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.5980 us/op 3.9980 us/op 0.90
mainnet_e58758 - phase0 afterProcessEpoch 96.557 ms/op 104.94 ms/op 0.92
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3861 ms/op 1.3876 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4584 ms/op 1.4292 ms/op 1.02
altair processInactivityUpdates - 250000 normalcase 26.624 ms/op 21.032 ms/op 1.27
altair processInactivityUpdates - 250000 worstcase 27.371 ms/op 21.931 ms/op 1.25
phase0 processRegistryUpdates - 250000 normalcase 7.2990 us/op 8.2060 us/op 0.89
phase0 processRegistryUpdates - 250000 badcase_full_deposits 330.93 us/op 311.41 us/op 1.06
phase0 processRegistryUpdates - 250000 worstcase 0.5 138.35 ms/op 145.39 ms/op 0.95
altair processRewardsAndPenalties - 250000 normalcase 57.466 ms/op 58.265 ms/op 0.99
altair processRewardsAndPenalties - 250000 worstcase 56.218 ms/op 58.078 ms/op 0.97
phase0 getAttestationDeltas - 250000 normalcase 9.3272 ms/op 9.3345 ms/op 1.00
phase0 getAttestationDeltas - 250000 worstcase 9.2008 ms/op 9.3447 ms/op 0.98
phase0 processSlashings - 250000 worstcase 81.052 us/op 84.376 us/op 0.96
altair processSyncCommitteeUpdates - 250000 155.32 ms/op 152.35 ms/op 1.02
BeaconState.hashTreeRoot - No change 356.00 ns/op 385.00 ns/op 0.92
BeaconState.hashTreeRoot - 1 full validator 128.68 us/op 135.38 us/op 0.95
BeaconState.hashTreeRoot - 32 full validator 1.5554 ms/op 1.3947 ms/op 1.12
BeaconState.hashTreeRoot - 512 full validator 17.372 ms/op 14.523 ms/op 1.20
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 181.91 us/op 172.59 us/op 1.05
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.4776 ms/op 2.5497 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 28.838 ms/op 34.243 ms/op 0.84
BeaconState.hashTreeRoot - 1 balances 141.46 us/op 140.03 us/op 1.01
BeaconState.hashTreeRoot - 32 balances 1.2245 ms/op 1.3222 ms/op 0.93
BeaconState.hashTreeRoot - 512 balances 11.637 ms/op 11.580 ms/op 1.00
BeaconState.hashTreeRoot - 250000 balances 198.40 ms/op 208.97 ms/op 0.95
aggregationBits - 2048 els - zipIndexesInBitList 17.215 us/op 17.441 us/op 0.99
byteArrayEquals 32 73.944 ns/op 84.475 ns/op 0.88
Buffer.compare 32 54.720 ns/op 63.893 ns/op 0.86
byteArrayEquals 1024 2.0353 us/op 2.3134 us/op 0.88
Buffer.compare 1024 69.262 ns/op 78.348 ns/op 0.88
byteArrayEquals 16384 32.380 us/op 36.617 us/op 0.88
Buffer.compare 16384 271.41 ns/op 299.35 ns/op 0.91
byteArrayEquals 123687377 242.21 ms/op 250.84 ms/op 0.97
Buffer.compare 123687377 6.0565 ms/op 6.0697 ms/op 1.00
byteArrayEquals 32 - diff last byte 71.537 ns/op 73.623 ns/op 0.97
Buffer.compare 32 - diff last byte 54.548 ns/op 66.627 ns/op 0.82
byteArrayEquals 1024 - diff last byte 1.9969 us/op 2.2182 us/op 0.90
Buffer.compare 1024 - diff last byte 68.192 ns/op 77.404 ns/op 0.88
byteArrayEquals 16384 - diff last byte 31.830 us/op 35.329 us/op 0.90
Buffer.compare 16384 - diff last byte 266.06 ns/op 252.87 ns/op 1.05
byteArrayEquals 123687377 - diff last byte 242.41 ms/op 263.93 ms/op 0.92
Buffer.compare 123687377 - diff last byte 6.3481 ms/op 6.3239 ms/op 1.00
byteArrayEquals 32 - random bytes 5.2620 ns/op 5.6040 ns/op 0.94
Buffer.compare 32 - random bytes 61.505 ns/op 65.095 ns/op 0.94
byteArrayEquals 1024 - random bytes 5.2250 ns/op 5.4870 ns/op 0.95
Buffer.compare 1024 - random bytes 58.688 ns/op 63.869 ns/op 0.92
byteArrayEquals 16384 - random bytes 5.1000 ns/op 5.4590 ns/op 0.93
Buffer.compare 16384 - random bytes 58.974 ns/op 64.328 ns/op 0.92
byteArrayEquals 123687377 - random bytes 8.1300 ns/op 8.7800 ns/op 0.93
Buffer.compare 123687377 - random bytes 61.550 ns/op 67.610 ns/op 0.91
regular array get 100000 times 43.475 us/op 46.406 us/op 0.94
wrappedArray get 100000 times 43.577 us/op 46.335 us/op 0.94
arrayWithProxy get 100000 times 13.852 ms/op 15.542 ms/op 0.89
ssz.Root.equals 52.912 ns/op 57.421 ns/op 0.92
byteArrayEquals 51.809 ns/op 56.420 ns/op 0.92
Buffer.compare 11.217 ns/op 11.674 ns/op 0.96
shuffle list - 16384 els 7.1005 ms/op 7.4414 ms/op 0.95
shuffle list - 250000 els 104.77 ms/op 114.09 ms/op 0.92
processSlot - 1 slots 16.400 us/op 17.876 us/op 0.92
processSlot - 32 slots 3.7137 ms/op 3.6131 ms/op 1.03
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 55.328 ms/op 59.843 ms/op 0.92
getCommitteeAssignments - req 1 vs - 250000 vc 2.5159 ms/op 2.5944 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 3.6968 ms/op 3.7729 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 4.0764 ms/op 4.1558 ms/op 0.98
findModifiedValidators - 10000 modified validators 543.65 ms/op 601.89 ms/op 0.90
findModifiedValidators - 1000 modified validators 414.07 ms/op 505.40 ms/op 0.82
findModifiedValidators - 100 modified validators 407.79 ms/op 472.83 ms/op 0.86
findModifiedValidators - 10 modified validators 422.45 ms/op 478.87 ms/op 0.88
findModifiedValidators - 1 modified validators 391.57 ms/op 487.18 ms/op 0.80
findModifiedValidators - no difference 405.05 ms/op 464.00 ms/op 0.87
compare ViewDUs 4.3327 s/op 4.4897 s/op 0.97
compare each validator Uint8Array 1.8590 s/op 1.9254 s/op 0.97
compare ViewDU to Uint8Array 1.1385 s/op 1.1934 s/op 0.95
migrate state 1000000 validators, 24 modified, 0 new 794.21 ms/op 827.39 ms/op 0.96
migrate state 1000000 validators, 1700 modified, 1000 new 1.0976 s/op 1.1299 s/op 0.97
migrate state 1000000 validators, 3400 modified, 2000 new 1.3150 s/op 1.3798 s/op 0.95
migrate state 1500000 validators, 24 modified, 0 new 808.55 ms/op 835.35 ms/op 0.97
migrate state 1500000 validators, 1700 modified, 1000 new 1.0464 s/op 1.1728 s/op 0.89
migrate state 1500000 validators, 3400 modified, 2000 new 1.3921 s/op 1.4004 s/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5000 ns/op 4.5000 ns/op 1.00
state getBlockRootAtSlot - 250000 vs - 7PWei 603.25 ns/op 747.79 ns/op 0.81
computeProposers - vc 250000 9.9807 ms/op 9.4483 ms/op 1.06
computeEpochShuffling - vc 250000 107.29 ms/op 107.19 ms/op 1.00
getNextSyncCommittee - vc 250000 162.57 ms/op 156.66 ms/op 1.04
computeSigningRoot for AttestationData 25.770 us/op 30.040 us/op 0.86
hash AttestationData serialized data then Buffer.toString(base64) 2.4525 us/op 2.5208 us/op 0.97
toHexString serialized data 1.1328 us/op 1.1499 us/op 0.99
Buffer.toString(base64) 231.79 ns/op 236.45 ns/op 0.98

by benchmarkbot/action

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #6368 (9c8f9ff) into unstable (291e178) will not change coverage.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6368   +/-   ##
=========================================
  Coverage     60.14%   60.14%           
=========================================
  Files           407      407           
  Lines         46490    46490           
  Branches       1545     1545           
=========================================
  Hits          27960    27960           
  Misses        18498    18498           
  Partials         32       32

matthewkeil
matthewkeil approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 although I would guess this gives @nazarhussain heartburn from having skipped tests pile up in the eslint output. Am curious if we should discuss how to handle stuff like this long term. Opened a discussion #6376

@wemeetagain wemeetagain merged commit f2e352f into unstable Jan 30, 2024
20 of 21 checks passed
@wemeetagain wemeetagain deleted the tuyen/skip_gossipsub_use_worker_e2e_tests branch January 30, 2024 22:54
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@matthewkeil matthewkeil matthewkeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @wemeetagain @matthewkeil