-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: subscribe to 2 long lived subnets per node #5704
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
8d344f9
to
27fb908
Compare
since there are only 2 long lived subnets anymore, node has to unsubscribe and resubscribe a lot which make it unstable need to wait for #5506 and a couple of new gossipsub PRs regarding |
25ae936
to
ce006a1
Compare
this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as you say, this is disabled by default. We can do more testing before turning this on.
const attnetsService = opts.deterministicLongLivedAttnets | ||
? new DLLAttnetsService(config, clock, gossip, metadata, logger, metrics, nodeId, opts) | ||
: new AttnetsService(config, clock, gossip, metadata, logger, metrics, opts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 This PR is included in v1.10.0 🎉 |
Motivation
Description
SUBNETS_PER_NODE
(2) long lived subnet based on node idIAttnetsService
calledDLLAttnetsService
for this--deterministicLongLivedAttnets
feature flag for this, disabled by defaultCloses #5546