test(prover): improve test coverage

[nazarhussain]

Motivation

Improve the test coverage for the prover package.

Description

• Move re-useable code to test-util package.
• Add tests to prover package
• Update the test code for other packages

Closes #5647

Run all tests.

[github-actions]

Performance Report

✔️ no performance regression detected

Full benchmark results

Benchmark suite	Current: c0d9e0f	Previous: 1de881b	Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc	687.53 us/op	984.46 us/op	0.70
getPubkeys - validatorsArr - req 1000 vs - 250000 vc	46.490 us/op	48.839 us/op	0.95
BLS verify - blst-native	1.2222 ms/op	1.2627 ms/op	0.97
BLS verifyMultipleSignatures 3 - blst-native	2.4933 ms/op	2.5589 ms/op	0.97
BLS verifyMultipleSignatures 8 - blst-native	5.2843 ms/op	5.5259 ms/op	0.96
BLS verifyMultipleSignatures 32 - blst-native	19.558 ms/op	20.010 ms/op	0.98
BLS aggregatePubkeys 32 - blst-native	25.986 us/op	26.753 us/op	0.97
BLS aggregatePubkeys 128 - blst-native	100.79 us/op	104.24 us/op	0.97
getAttestationsForBlock	52.706 ms/op	58.667 ms/op	0.90
isKnown best case - 1 super set check	246.00 ns/op	266.00 ns/op	0.92
isKnown normal case - 2 super set checks	248.00 ns/op	255.00 ns/op	0.97
isKnown worse case - 16 super set checks	241.00 ns/op	255.00 ns/op	0.95
CheckpointStateCache - add get delete	5.0930 us/op	5.8060 us/op	0.88
validate gossip signedAggregateAndProof - struct	2.7391 ms/op	2.8317 ms/op	0.97
validate gossip attestation - struct	1.3043 ms/op	1.3537 ms/op	0.96
pickEth1Vote - no votes	1.2662 ms/op	1.3381 ms/op	0.95
pickEth1Vote - max votes	11.944 ms/op	11.704 ms/op	1.02
pickEth1Vote - Eth1Data hashTreeRoot value x2048	9.0639 ms/op	9.3203 ms/op	0.97
pickEth1Vote - Eth1Data hashTreeRoot tree x2048	14.119 ms/op	16.628 ms/op	0.85
pickEth1Vote - Eth1Data fastSerialize value x2048	649.38 us/op	740.25 us/op	0.88
pickEth1Vote - Eth1Data fastSerialize tree x2048	4.4526 ms/op	5.2671 ms/op	0.85
bytes32 toHexString	489.00 ns/op	549.00 ns/op	0.89
bytes32 Buffer.toString(hex)	347.00 ns/op	390.00 ns/op	0.89
bytes32 Buffer.toString(hex) from Uint8Array	539.00 ns/op	604.00 ns/op	0.89
bytes32 Buffer.toString(hex) + 0x	341.00 ns/op	397.00 ns/op	0.86
Object access 1 prop	0.16100 ns/op	0.18000 ns/op	0.89
Map access 1 prop	0.16000 ns/op	0.16400 ns/op	0.98
Object get x1000	6.9100 ns/op	6.6030 ns/op	1.05
Map get x1000	0.61100 ns/op	0.64500 ns/op	0.95
Object set x1000	51.452 ns/op	59.775 ns/op	0.86
Map set x1000	43.751 ns/op	47.754 ns/op	0.92
Return object 10000 times	0.23820 ns/op	0.24880 ns/op	0.96
Throw Error 10000 times	4.1643 us/op	4.4212 us/op	0.94
fastMsgIdFn sha256 / 200 bytes	3.4340 us/op	3.7200 us/op	0.92
fastMsgIdFn h32 xxhash / 200 bytes	288.00 ns/op	334.00 ns/op	0.86
fastMsgIdFn h64 xxhash / 200 bytes	383.00 ns/op	452.00 ns/op	0.85
fastMsgIdFn sha256 / 1000 bytes	11.548 us/op	12.005 us/op	0.96
fastMsgIdFn h32 xxhash / 1000 bytes	425.00 ns/op	456.00 ns/op	0.93
fastMsgIdFn h64 xxhash / 1000 bytes	459.00 ns/op	521.00 ns/op	0.88
fastMsgIdFn sha256 / 10000 bytes	103.96 us/op	106.31 us/op	0.98
fastMsgIdFn h32 xxhash / 10000 bytes	1.9540 us/op	2.0300 us/op	0.96
fastMsgIdFn h64 xxhash / 10000 bytes	1.4120 us/op	1.4630 us/op	0.97
enrSubnets - fastDeserialize 64 bits	1.2850 us/op	1.4460 us/op	0.89
enrSubnets - ssz BitVector 64 bits	483.00 ns/op	586.00 ns/op	0.82
enrSubnets - fastDeserialize 4 bits	178.00 ns/op	194.00 ns/op	0.92
enrSubnets - ssz BitVector 4 bits	492.00 ns/op	552.00 ns/op	0.89
prioritizePeers score -10:0 att 32-0.1 sync 2-0	105.23 us/op	120.53 us/op	0.87
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25	136.58 us/op	159.66 us/op	0.86
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5	174.01 us/op	193.01 us/op	0.90
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75	309.27 us/op	360.78 us/op	0.86
prioritizePeers score 0:0 att 64-1 sync 4-1	378.65 us/op	443.84 us/op	0.85
array of 16000 items push then shift	1.6364 us/op	1.7121 us/op	0.96
LinkedList of 16000 items push then shift	8.8510 ns/op	9.2090 ns/op	0.96
array of 16000 items push then pop	83.016 ns/op	111.60 ns/op	0.74
LinkedList of 16000 items push then pop	8.4020 ns/op	8.9420 ns/op	0.94
array of 24000 items push then shift	2.2859 us/op	2.4249 us/op	0.94
LinkedList of 24000 items push then shift	8.9310 ns/op	9.7730 ns/op	0.91
array of 24000 items push then pop	74.230 ns/op	91.895 ns/op	0.81
LinkedList of 24000 items push then pop	8.6430 ns/op	9.4110 ns/op	0.92
intersect bitArray bitLen 8	13.143 ns/op	14.079 ns/op	0.93
intersect array and set length 8	78.529 ns/op	84.893 ns/op	0.93
intersect bitArray bitLen 128	43.752 ns/op	46.338 ns/op	0.94
intersect array and set length 128	1.0761 us/op	1.1663 us/op	0.92
Buffer.concat 32 items	2.9000 us/op	3.0450 us/op	0.95
Uint8Array.set 32 items	2.0570 us/op	2.3010 us/op	0.89
transfer serialized Status (84 B)	2.0730 us/op	2.1190 us/op	0.98
copy serialized Status (84 B)	1.6700 us/op	1.8050 us/op	0.93
transfer serialized SignedVoluntaryExit (112 B)	2.0360 us/op	2.1600 us/op	0.94
copy serialized SignedVoluntaryExit (112 B)	1.6520 us/op	1.7610 us/op	0.94
transfer serialized ProposerSlashing (416 B)	3.1140 us/op	2.4540 us/op	1.27
copy serialized ProposerSlashing (416 B)	3.2100 us/op	2.8360 us/op	1.13
transfer serialized Attestation (485 B)	3.5120 us/op	2.4520 us/op	1.43
copy serialized Attestation (485 B)	3.1360 us/op	2.1140 us/op	1.48
transfer serialized AttesterSlashing (33232 B)	3.2500 us/op	2.5240 us/op	1.29
copy serialized AttesterSlashing (33232 B)	5.9250 us/op	6.2040 us/op	0.96
transfer serialized Small SignedBeaconBlock (128000 B)	2.9130 us/op	2.9310 us/op	0.99
copy serialized Small SignedBeaconBlock (128000 B)	11.959 us/op	16.968 us/op	0.70
transfer serialized Avg SignedBeaconBlock (200000 B)	3.0740 us/op	3.2320 us/op	0.95
copy serialized Avg SignedBeaconBlock (200000 B)	60.218 us/op	20.748 us/op	2.90
transfer serialized BlobsSidecar (524380 B)	2.8450 us/op	3.3390 us/op	0.85
copy serialized BlobsSidecar (524380 B)	173.23 us/op	76.840 us/op	2.25
transfer serialized Big SignedBeaconBlock (1000000 B)	2.9610 us/op	3.8280 us/op	0.77
copy serialized Big SignedBeaconBlock (1000000 B)	245.22 us/op	258.18 us/op	0.95
pass gossip attestations to forkchoice per slot	2.6239 ms/op	2.9253 ms/op	0.90
forkChoice updateHead vc 100000 bc 64 eq 0	2.0204 ms/op	2.1549 ms/op	0.94
forkChoice updateHead vc 600000 bc 64 eq 0	11.535 ms/op	12.488 ms/op	0.92
forkChoice updateHead vc 1000000 bc 64 eq 0	21.769 ms/op	24.177 ms/op	0.90
forkChoice updateHead vc 600000 bc 320 eq 0	16.803 ms/op	17.458 ms/op	0.96
forkChoice updateHead vc 600000 bc 1200 eq 0	80.129 ms/op	90.044 ms/op	0.89
forkChoice updateHead vc 600000 bc 64 eq 1000	20.818 ms/op	22.252 ms/op	0.94
forkChoice updateHead vc 600000 bc 64 eq 10000	23.205 ms/op	24.022 ms/op	0.97
forkChoice updateHead vc 600000 bc 64 eq 300000	31.450 ms/op	33.278 ms/op	0.95
computeDeltas	3.3073 ms/op	3.2723 ms/op	1.01
computeProposerBoostScoreFromBalances	1.7546 ms/op	2.0087 ms/op	0.87
altair processAttestation - 250000 vs - 7PWei normalcase	2.3082 ms/op	3.4879 ms/op	0.66
altair processAttestation - 250000 vs - 7PWei worstcase	3.5696 ms/op	5.1668 ms/op	0.69
altair processAttestation - setStatus - 1/6 committees join	136.53 us/op	158.78 us/op	0.86
altair processAttestation - setStatus - 1/3 committees join	277.29 us/op	311.97 us/op	0.89
altair processAttestation - setStatus - 1/2 committees join	368.22 us/op	413.01 us/op	0.89
altair processAttestation - setStatus - 2/3 committees join	463.12 us/op	524.75 us/op	0.88
altair processAttestation - setStatus - 4/5 committees join	629.00 us/op	751.72 us/op	0.84
altair processAttestation - setStatus - 100% committees join	756.46 us/op	889.19 us/op	0.85
altair processBlock - 250000 vs - 7PWei normalcase	16.386 ms/op	22.993 ms/op	0.71
altair processBlock - 250000 vs - 7PWei normalcase hashState	24.214 ms/op	31.703 ms/op	0.76
altair processBlock - 250000 vs - 7PWei worstcase	45.448 ms/op	66.383 ms/op	0.68
altair processBlock - 250000 vs - 7PWei worstcase hashState	67.437 ms/op	88.704 ms/op	0.76
phase0 processBlock - 250000 vs - 7PWei normalcase	2.2416 ms/op	2.8287 ms/op	0.79
phase0 processBlock - 250000 vs - 7PWei worstcase	29.133 ms/op	36.698 ms/op	0.79
altair processEth1Data - 250000 vs - 7PWei normalcase	471.08 us/op	653.72 us/op	0.72
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15	7.8420 us/op	12.857 us/op	0.61
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219	25.172 us/op	34.819 us/op	0.72
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42	9.8160 us/op	13.932 us/op	0.70
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18	7.5720 us/op	9.3570 us/op	0.81
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020	93.630 us/op	112.12 us/op	0.84
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777	641.34 us/op	708.70 us/op	0.90
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384	889.32 us/op	926.93 us/op	0.96
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384	886.85 us/op	929.15 us/op	0.95
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384	2.3297 ms/op	2.8703 ms/op	0.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384	1.5137 ms/op	1.6444 ms/op	0.92
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384	3.9870 ms/op	4.8783 ms/op	0.82
Tree 40 250000 create	321.32 ms/op	383.95 ms/op	0.84
Tree 40 250000 get(125000)	187.05 ns/op	215.83 ns/op	0.87
Tree 40 250000 set(125000)	926.72 ns/op	1.1681 us/op	0.79
Tree 40 250000 toArray()	20.844 ms/op	24.148 ms/op	0.86
Tree 40 250000 iterate all - toArray() + loop	20.273 ms/op	24.631 ms/op	0.82
Tree 40 250000 iterate all - get(i)	70.812 ms/op	81.581 ms/op	0.87
MutableVector 250000 create	9.2275 ms/op	12.367 ms/op	0.75
MutableVector 250000 get(125000)	6.2580 ns/op	6.8660 ns/op	0.91
MutableVector 250000 set(125000)	261.57 ns/op	331.76 ns/op	0.79
MutableVector 250000 toArray()	3.8277 ms/op	4.6915 ms/op	0.82
MutableVector 250000 iterate all - toArray() + loop	3.4831 ms/op	4.3761 ms/op	0.80
MutableVector 250000 iterate all - get(i)	1.5155 ms/op	1.6486 ms/op	0.92
Array 250000 create	2.9709 ms/op	3.7896 ms/op	0.78
Array 250000 clone - spread	1.1592 ms/op	1.3139 ms/op	0.88
Array 250000 get(125000)	0.54400 ns/op	0.60700 ns/op	0.90
Array 250000 set(125000)	0.59400 ns/op	0.68700 ns/op	0.86
Array 250000 iterate all - loop	82.465 us/op	93.991 us/op	0.88
effectiveBalanceIncrements clone Uint8Array 300000	31.449 us/op	43.743 us/op	0.72
effectiveBalanceIncrements clone MutableVector 300000	322.00 ns/op	377.00 ns/op	0.85
effectiveBalanceIncrements rw all Uint8Array 300000	164.94 us/op	179.12 us/op	0.92
effectiveBalanceIncrements rw all MutableVector 300000	78.781 ms/op	94.461 ms/op	0.83
phase0 afterProcessEpoch - 250000 vs - 7PWei	112.82 ms/op	130.47 ms/op	0.86
phase0 beforeProcessEpoch - 250000 vs - 7PWei	42.364 ms/op	44.216 ms/op	0.96
altair processEpoch - mainnet_e81889	333.21 ms/op	338.86 ms/op	0.98
mainnet_e81889 - altair beforeProcessEpoch	65.657 ms/op	68.892 ms/op	0.95
mainnet_e81889 - altair processJustificationAndFinalization	18.510 us/op	17.714 us/op	1.04
mainnet_e81889 - altair processInactivityUpdates	5.6435 ms/op	5.8193 ms/op	0.97
mainnet_e81889 - altair processRewardsAndPenalties	68.252 ms/op	66.402 ms/op	1.03
mainnet_e81889 - altair processRegistryUpdates	2.8250 us/op	2.7130 us/op	1.04
mainnet_e81889 - altair processSlashings	473.00 ns/op	514.00 ns/op	0.92
mainnet_e81889 - altair processEth1DataReset	530.00 ns/op	563.00 ns/op	0.94
mainnet_e81889 - altair processEffectiveBalanceUpdates	1.2646 ms/op	1.3490 ms/op	0.94
mainnet_e81889 - altair processSlashingsReset	3.7280 us/op	4.2900 us/op	0.87
mainnet_e81889 - altair processRandaoMixesReset	4.1950 us/op	10.727 us/op	0.39
mainnet_e81889 - altair processHistoricalRootsUpdate	706.00 ns/op	2.2930 us/op	0.31
mainnet_e81889 - altair processParticipationFlagUpdates	2.9300 us/op	3.4640 us/op	0.85
mainnet_e81889 - altair processSyncCommitteeUpdates	581.00 ns/op	1.1210 us/op	0.52
mainnet_e81889 - altair afterProcessEpoch	129.77 ms/op	134.66 ms/op	0.96
phase0 processEpoch - mainnet_e58758	361.59 ms/op	407.14 ms/op	0.89
mainnet_e58758 - phase0 beforeProcessEpoch	141.28 ms/op	166.38 ms/op	0.85
mainnet_e58758 - phase0 processJustificationAndFinalization	15.048 us/op	24.653 us/op	0.61
mainnet_e58758 - phase0 processRewardsAndPenalties	64.666 ms/op	72.179 ms/op	0.90
mainnet_e58758 - phase0 processRegistryUpdates	7.7830 us/op	8.7240 us/op	0.89
mainnet_e58758 - phase0 processSlashings	487.00 ns/op	1.1390 us/op	0.43
mainnet_e58758 - phase0 processEth1DataReset	499.00 ns/op	552.00 ns/op	0.90
mainnet_e58758 - phase0 processEffectiveBalanceUpdates	1.0018 ms/op	1.0531 ms/op	0.95
mainnet_e58758 - phase0 processSlashingsReset	3.5810 us/op	4.3310 us/op	0.83
mainnet_e58758 - phase0 processRandaoMixesReset	3.7330 us/op	4.9150 us/op	0.76
mainnet_e58758 - phase0 processHistoricalRootsUpdate	609.00 ns/op	997.00 ns/op	0.61
mainnet_e58758 - phase0 processParticipationRecordUpdates	4.6470 us/op	5.2720 us/op	0.88
mainnet_e58758 - phase0 afterProcessEpoch	98.141 ms/op	102.28 ms/op	0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase	1.2302 ms/op	1.2997 ms/op	0.95
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5	1.5049 ms/op	1.6501 ms/op	0.91
altair processInactivityUpdates - 250000 normalcase	23.181 ms/op	26.447 ms/op	0.88
altair processInactivityUpdates - 250000 worstcase	26.254 ms/op	27.062 ms/op	0.97
phase0 processRegistryUpdates - 250000 normalcase	7.3200 us/op	7.5320 us/op	0.97
phase0 processRegistryUpdates - 250000 badcase_full_deposits	237.93 us/op	266.04 us/op	0.89
phase0 processRegistryUpdates - 250000 worstcase 0.5	126.87 ms/op	130.00 ms/op	0.98
altair processRewardsAndPenalties - 250000 normalcase	70.373 ms/op	68.428 ms/op	1.03
altair processRewardsAndPenalties - 250000 worstcase	71.168 ms/op	70.486 ms/op	1.01
phase0 getAttestationDeltas - 250000 normalcase	7.1027 ms/op	7.7426 ms/op	0.92
phase0 getAttestationDeltas - 250000 worstcase	6.8024 ms/op	6.9577 ms/op	0.98
phase0 processSlashings - 250000 worstcase	3.5724 ms/op	3.7399 ms/op	0.96
altair processSyncCommitteeUpdates - 250000	177.12 ms/op	183.80 ms/op	0.96
BeaconState.hashTreeRoot - No change	261.00 ns/op	271.00 ns/op	0.96
BeaconState.hashTreeRoot - 1 full validator	52.244 us/op	54.495 us/op	0.96
BeaconState.hashTreeRoot - 32 full validator	583.33 us/op	496.24 us/op	1.18
BeaconState.hashTreeRoot - 512 full validator	5.4100 ms/op	5.1719 ms/op	1.05
BeaconState.hashTreeRoot - 1 validator.effectiveBalance	67.197 us/op	68.020 us/op	0.99
BeaconState.hashTreeRoot - 32 validator.effectiveBalance	886.72 us/op	912.45 us/op	0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance	11.252 ms/op	12.173 ms/op	0.92
BeaconState.hashTreeRoot - 1 balances	48.425 us/op	51.570 us/op	0.94
BeaconState.hashTreeRoot - 32 balances	441.94 us/op	467.63 us/op	0.95
BeaconState.hashTreeRoot - 512 balances	4.5014 ms/op	4.3964 ms/op	1.02
BeaconState.hashTreeRoot - 250000 balances	73.789 ms/op	78.123 ms/op	0.94
aggregationBits - 2048 els - zipIndexesInBitList	15.366 us/op	17.208 us/op	0.89
regular array get 100000 times	33.300 us/op	34.031 us/op	0.98
wrappedArray get 100000 times	32.840 us/op	34.113 us/op	0.96
arrayWithProxy get 100000 times	15.481 ms/op	17.674 ms/op	0.88
ssz.Root.equals	552.00 ns/op	569.00 ns/op	0.97
byteArrayEquals	540.00 ns/op	572.00 ns/op	0.94
shuffle list - 16384 els	6.7919 ms/op	7.0876 ms/op	0.96
shuffle list - 250000 els	99.356 ms/op	104.13 ms/op	0.95
processSlot - 1 slots	8.4580 us/op	9.4990 us/op	0.89
processSlot - 32 slots	1.2972 ms/op	1.3933 ms/op	0.93
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei	36.178 ms/op	36.077 ms/op	1.00
getCommitteeAssignments - req 1 vs - 250000 vc	2.9364 ms/op	3.0018 ms/op	0.98
getCommitteeAssignments - req 100 vs - 250000 vc	4.1233 ms/op	4.2662 ms/op	0.97
getCommitteeAssignments - req 1000 vs - 250000 vc	4.4502 ms/op	4.5952 ms/op	0.97
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei	4.6900 ns/op	4.9100 ns/op	0.96
state getBlockRootAtSlot - 250000 vs - 7PWei	977.33 ns/op	616.77 ns/op	1.58
computeProposers - vc 250000	10.459 ms/op	11.119 ms/op	0.94
computeEpochShuffling - vc 250000	105.31 ms/op	108.83 ms/op	0.97
getNextSyncCommittee - vc 250000	178.41 ms/op	195.11 ms/op	0.91
computeSigningRoot for AttestationData	13.479 us/op	14.130 us/op	0.95
hash AttestationData serialized data then Buffer.toString(base64)	2.4445 us/op	2.5838 us/op	0.95
toHexString serialized data	1.0937 us/op	1.2612 us/op	0.87
Buffer.toString(base64)	340.38 ns/op	346.90 ns/op	0.98

by benchmarkbot/action

[nflaig]

Refactoring looks pretty good but this PR is really hard to review, git diff is lost for a lot of files.

Might want to split this up into two PRs

• one that refactors existing tests and extracts utils to @lodestar/test-util
• and a 2nd PR that adds prover tests

Would suggest a 2nd review from someone else

[nflaig]

Looks good to me, keeping this PR open to give others the opportunity for a final review

[nazarhussain]

It looks like running a custom devnet with proxy is behaving differently than the mainnet. Making this PR to draft temporarily to fix it.

[wemeetagain]

we can't run with ts-node anymore, we have to do node --loader ts-node/esm

[nazarhussain]

It was running with ts-node, though now I have changed the implementation to use node --loader ts-node/esm.

[wemeetagain]

🎉 This PR is included in v1.10.0 🎉