Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make peer score use component logger #476

Conversation

achingbrain
Copy link
Collaborator

Follow up to #473 - makes PeerScore use the configured component logger instead of creating a new one.

Follow up to ChainSafe#473 - makes `PeerScore` use the configured component
logger instead of creating a new one.
@achingbrain achingbrain requested a review from a team as a code owner December 4, 2023 13:01
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (bf02df0) 81.37% compared to head (337b2e6) 81.36%.

Files Patch % Lines
src/score/peer-score.ts 60.00% 4 Missing ⚠️
test/peer-score.spec.ts 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   81.37%   81.36%   -0.02%     
==========================================
  Files          48       48              
  Lines       12268    12275       +7     
  Branches     1292     1291       -1     
==========================================
+ Hits         9983     9987       +4     
- Misses       2285     2288       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wemeetagain wemeetagain merged commit dba38d1 into ChainSafe:master Dec 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants