Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add an umbrella page for CS Filecoin services #5182

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 24, 2025

Summary of changes

Changes introduced in this pull request:

  • added an umbrella page for Chainsafe's Filecoin services (potentially to be a redirect for filecoin.chainsafe.io

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the umbrella-page-fil-services branch 2 times, most recently from 3734195 to 82cb613 Compare January 24, 2025 13:14
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review January 24, 2025 13:45
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 24, 2025 13:45
@LesnyRumcajs LesnyRumcajs requested review from lemmih and removed request for a team January 24, 2025 13:45
Copy link
Member

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my two cents 🦐

docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
docs/docs/users/filecoin_services.md Show resolved Hide resolved
docs/docs/users/filecoin_services.md Show resolved Hide resolved
docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
@LesnyRumcajs
Copy link
Member Author

@ansermino Changed it a bit to address some of your comments (mainly regarding the page being Forest-centric).

Copy link
Member

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Would be nice to expand over time but this is a great start

docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
docs/docs/users/filecoin_services.md Outdated Show resolved Hide resolved
@LesnyRumcajs LesnyRumcajs force-pushed the umbrella-page-fil-services branch from b6509f0 to d32674f Compare February 5, 2025 14:18
@LesnyRumcajs LesnyRumcajs force-pushed the umbrella-page-fil-services branch from 3b43ce3 to 1c50e9d Compare February 5, 2025 14:21
@ansermino ansermino added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 6408e15 Feb 5, 2025
16 checks passed
@ansermino ansermino deleted the umbrella-page-fil-services branch February 5, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants