Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(f3): implement Finalize for EC backend #4897

Merged
merged 9 commits into from
Oct 16, 2024
Merged

feat(f3): implement Finalize for EC backend #4897

merged 9 commits into from
Oct 16, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 15, 2024 •
edited
Loading

Summary of changes

See #4876 for details

Changes introduced in this pull request:

  • implement Finalize for EC(expected consensus) backend
  • add f3_enabled and f3_consensus to ChainConfig
  • adjust F3 sidecar log levels
  • fix CommitteeLookback setting in F3 sidecar manifest to align with Lotus
  • env var docs updated in https://github.com/ChainSafe/forest-docs-v2/pull/92

Reference issue to close (if applicable)

Closes #4876

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 15, 2024 09:13
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 15, 2024 09:13
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team October 15, 2024 09:13
@lemmih lemmih added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 7b3b90f Oct 16, 2024
33 checks passed
@lemmih lemmih deleted the hm/F3Finalize branch October 16, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[F3] Implement F3.Finalize RPC method
3 participants
@hanabi1224 @lemmih @LesnyRumcajs