Skip to content

ci(docker): hotfix the trigger of publishing docker images by tags #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Apr 28, 2021

This is really a small fix, I can embed this into my next PR or @mattsse doesn't mind adding this fix to your pending PRs?

Changes

Forgot to ignore all branches in my last PR #49, and here is the doc of CircieCI tag trigger, Executing workflows for a git tag

Tests

Tested on my private repo, echo-when-tag, it would be nice downloading the testing config.yml or merge this branch into a personal fork of PINT to test this instruction


BTW, can anybody delete this test release?

@clearloop clearloop added the needs review PR needs reviewing label Apr 28, 2021
@clearloop clearloop marked this pull request as draft April 28, 2021 15:12
@dutterbutter dutterbutter marked this pull request as ready for review April 29, 2021 13:50
@dutterbutter dutterbutter requested a review from mattsse April 29, 2021 13:50
@dutterbutter dutterbutter added the chore Maintenance related work label Apr 29, 2021
@mattsse mattsse merged commit 0e9930d into main Apr 30, 2021
@mattsse mattsse deleted the cl/hotfix-docker-publish branch April 30, 2021 12:50
@clearloop clearloop added approved PR approved to merge and removed needs review PR needs reviewing labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approved to merge chore Maintenance related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants