fix border-radius #255
Merged
fix border-radius #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaut
reviewed
Jul 14, 2023
| @@ -141,7 +141,7 @@ export default styled(Transaction)( | |||
| max-height: 1.3125rem; | |||
| left: 29px; | |||
| top: 19px; | |||
| border-radius: 0 0.9375rem 0.9375rem 0.9375rem; | |||
| border-radius: ${theme.custom.borderRadius}; | |||
There was a problem hiding this comment.
This breaks the effect of having the top left not having any in the top left. Not sure if this suggestion works, we we could try
Suggested change
| border-radius: ${theme.custom.borderRadius}; | |
| border-radius: 0 ${theme.custom.borderRadius} ${theme.custom.borderRadius} ${theme.custom.borderRadius}; |
There was a problem hiding this comment.
The new design doesn't have that view for the badge. So we can consider it deprecated and keep the new design
There was a problem hiding this comment.
this is not implementing the new design though, we're in the old, changing border-radius. Now if that's something you've strong opinion about, because you don't like it, I can let it go.
Tbaut
approved these changes
Jul 14, 2023
|
I guess it's ready to merge? |
Now we can merge, got the reply from Cindy about unified border-radius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253