Skip to content

Commit

Permalink
fix reject
Browse files Browse the repository at this point in the history
  • Loading branch information
Tbaut committed Aug 2, 2023
1 parent 1a082f5 commit 22a284f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/ui/src/components/modals/ProposalSigning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,15 @@ const ProposalSigning = ({
proposalData.callData || addedCallData
)
const mustSubmitCallData = useMemo(() => {
// the proposer can only reject, and the calldata isn't needed for this
if (isProposerSelected) return false

if (!threshold || !proposalData.info?.approvals) return true

// if it's the last approval call, we must use asMulti and have the call data
// either from the chain, or from users
return proposalData.info?.approvals.length >= threshold - 1
}, [proposalData, threshold])
}, [isProposerSelected, proposalData.info?.approvals, threshold])
const onSubmitting = useCallback(() => {
setIsSubmitting(false)
onClose()
Expand Down

0 comments on commit 22a284f

Please sign in to comment.