Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to check CAIPs #182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add workflow to check CAIPs #182

wants to merge 2 commits into from

Conversation

ligi
Copy link
Member

@ligi ligi commented Nov 20, 2022

#181 needs to be merged first

@ligi ligi force-pushed the check_workflow branch 2 times, most recently from 5ae5dba to 6ab049a Compare November 20, 2022 01:45
@ritave
Copy link
Contributor

ritave commented Nov 20, 2022

Wouldn't you prefer to use something already built instead of rebuilding a new one?

I've written a re-usable markdown linter for SIPs, which operates on Abstract Syntax Tree of markdown and allows writing custom rules per repository.

For example, this rule checks any external links for 400 statues by visiting specific nodes in AST.

I could release the linter into MIT and publish on NPM and allow it to load CAIPs specific plugins.

Especially since most of CAIPs operate on TypeScript's types and general Web ecosystem assumptions. And while I like Kotlin since I've been writing in it professionally for few years, it's not the language users of this repo will be most familiar with.

@ligi
Copy link
Member Author

ligi commented Nov 21, 2022

This is reused - I used it for DIPs before. Link checker there I used another one before - gaurav-nelson/github-action-markdown-link-check@v1 - but actually removed it from this step as Link checking is not deterministic.
Feel free to add yours afterwards - this already found stuff and can guard until something else is in place.

@ritave
Copy link
Contributor

ritave commented Nov 21, 2022

I'm good with whichever if we're reusing and not writing one anew again.

@bumblefudge
Copy link
Collaborator

#181 merged. Maybe force-push to see if CI will re-run?

@obstropolos
Copy link
Contributor

@ligi - is this all working?

@obstropolos
Copy link
Contributor

@ligi - doing some quick housekeeping - is this all working / some conflicts to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants