Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tox21MolNet #56

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Refactor Tox21MolNet #56

wants to merge 3 commits into from

Conversation

aditya0by0
Copy link
Collaborator

@aditya0by0 aditya0by0 commented Sep 25, 2024

Note:
This came up when adding unit tests for this class. Therefore, we should also include them when solving this PR (see #45 ).

@aditya0by0 aditya0by0 linked an issue Sep 25, 2024 that may be closed by this pull request
3 tasks
@aditya0by0 aditya0by0 self-assigned this Sep 25, 2024
@aditya0by0 aditya0by0 mentioned this pull request Sep 25, 2024
31 tasks
@sfluegel05
Copy link
Collaborator

Could you give me the command you used for the tox21 dataset? I have some trouble loading it (probably not related to this issue)

@aditya0by0
Copy link
Collaborator Author

Could you give me the command you used for the tox21 dataset? I have some trouble loading it (probably not related to this issue)

I don't have the exact command, as I just called the method on the object of the class. I was mainly focused on testing the method rather than the specific command.

@sfluegel05 sfluegel05 marked this pull request as ready for review October 1, 2024 13:05
@sfluegel05
Copy link
Collaborator

I had some trouble with the download function:

  File "C:\Users\Simon Flügel\AppData\Local\Programs\Python\Python311\Lib\urllib\request.py", line 251, in urlretrieve
tfp = open(filename, 'wb')
      ^^^^^^^^^^^^^^^^^^^^
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\SIMONF~1\\AppData\\Local\\Temp\\tmpjwyb15vt'

This is not an error with the file location not being accessible, but (as far as I understand), the download function first opens a temporary file and then calls urlretrieve for the file name.
This should be fixed by commit 29cff11

However, this still does not lead to a functioning dataset - the class does not apply any tokenisation and the collate function receives an unprocessed SMILES string.
@MGlauer You have done some runs with the MolNet class - did you use an already existing dataset or do you have another preprocessing pipeline for the Tox21MolNet dataset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technical issues in Tox21MolNet + corresponding Tests
2 participants