-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Tox21MolNet #56
base: dev
Are you sure you want to change the base?
Conversation
Could you give me the command you used for the tox21 dataset? I have some trouble loading it (probably not related to this issue) |
I don't have the exact command, as I just called the method on the object of the class. I was mainly focused on testing the method rather than the specific command. |
I had some trouble with the
This is not an error with the file location not being accessible, but (as far as I understand), the download function first opens a temporary file and then calls However, this still does not lead to a functioning dataset - the class does not apply any tokenisation and the collate function receives an unprocessed SMILES string. |
Issue: Technical issues in
Tox21MolNet
+corresponding Tests
#53Note:
This came up when adding unit tests for this class. Therefore, we should also include them when solving this PR (see #45 ).