Ext mesh features id clarifications #66
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propertyTable
of a feature ID should be aglTFid
, and not a plaininteger
( glTF metadata uses integers where it should use "glTF IDs" 3d-tiles#751 )featureCount
andnullFeatureId
3d-tiles#756This might be fixing CesiumGS/3d-tiles#756 . One aspect of that issue was whether the
featureCount
is actually required. But there likely are cases where implementors might need this information (so it is unlikely that it will be removed from the specification). And regardless of whether it will be removed or not: As long as it is still contained in the specification, the implementation note should help to clarify its meaning.