Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext mesh features id clarifications #66

Closed

Conversation

javagl
Copy link

@javagl javagl commented May 18, 2024

This might be fixing CesiumGS/3d-tiles#756 . One aspect of that issue was whether the featureCount is actually required. But there likely are cases where implementors might need this information (so it is unlikely that it will be removed from the specification). And regardless of whether it will be removed or not: As long as it is still contained in the specification, the implementation note should help to clarify its meaning.

@lilleyse
Copy link

@javagl could you open a separate PR for the glTFid change? I'm happy to merge that but need to think more about the clarifications for CesiumGS/3d-tiles#756.

@javagl
Copy link
Author

javagl commented May 20, 2024

New PR at #68

@javagl
Copy link
Author

javagl commented May 22, 2024

(I think this is obsolete an replaced by #68 now - possible changes for the nullFeatureId and featureCount are independent of this)

@javagl javagl closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants