Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11787 – Improve scene height picking performance #11792

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jan 29, 2024

Description

  • Pulls in some performance fixes from 3d tiles height reference #11604 (whichever gets merged first is fine)
  • Don't pick the ground height each frame: Only when the camera moves or when additional data is loaded.
  • Configure the powerplant tileset to skip camera collision as it is an "indoor tileset"

Issue number and link

Fixes #11787

Testing plan

Add the following line to any Sandcastle example to check the framerate:

viewer.scene.debugShowFramesPerSecond = true;
  • Open and move around updated sandcastle examples, verifying thee frame rate is not impacted and that you can navigate inside the powerplant tileset
  • Verify other 3D tiles examples, such the Google examples, and confirm frame rate isn't significantly impacted

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • [ ]I have updated CHANGES.md with a short summary of my change Not needed, the original feature has not yet been shipped
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@ggetz
Copy link
Contributor Author

ggetz commented Jan 31, 2024

@jjspace can you please review?

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good and most of the Sandcastles run much smoother.

I did notice pretty bad framerate in the 3D Tiles Clipping Planes and MSAA Sandcastles still.

I just had one small question. Also please merge main 🙏

packages/engine/Source/Scene/Scene.js Show resolved Hide resolved
@ggetz ggetz force-pushed the pick-model-performance branch from 27d2c2f to 9326aaa Compare February 1, 2024 13:46
@ggetz
Copy link
Contributor Author

ggetz commented Feb 1, 2024

Thanks @jjspace, this should be ready to go.

@jjspace jjspace merged commit 176bd4e into main Feb 1, 2024
9 checks passed
@jjspace jjspace deleted the pick-model-performance branch February 1, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D Tiles BIM sandcastle low FPS when zoomed in
2 participants