Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uriparser usage with CesiumUtility::Uri #1589

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Replace uriparser usage with CesiumUtility::Uri #1589

merged 5 commits into from
Feb 1, 2025

Conversation

azrogers
Copy link
Contributor

With uriparser getting replaced with ada in CesiumGS/cesium-native#1072, we need to remove the usage of uriparser in Cesium for Unreal so we can remove it from the dependencies entirely. This change utilizes the CesiumUtility::Uri::uriPathToNativePath and CesiumUtility::Uri::getPath methods to resolve file URIs. As part of it, I needed to wrap includes of CesiumUtility/Uri.h in THIRD_PARTY_INCLUDES_START and _END macros as ada references multiple macros in #if directives, such as ADA_USING_LIBRARY, that aren't necessarily defined. This causes errors on MSVC. The THIRD_PARTY_INCLUDES_ macros ignore errors in the included header files.

@kring kring added this to the February 2025 Release milestone Jan 31, 2025
@kring
Copy link
Member

kring commented Feb 1, 2025

Thanks @azrogers!

@kring kring merged commit f78cb02 into main Feb 1, 2025
23 checks passed
@kring kring deleted the ada-url branch February 1, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants