Add RequestHeaders property to Cesium3DTileset
#1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kring
reviewed
Jan 16, 2025
…unreal into request-headers-tileset
…o request-headers-tileset
…unreal into request-headers-tileset
kring
reviewed
Jan 29, 2025
| @@ -385,6 +385,31 @@ void ACesium3DTileset::SetTilesetSource(ETilesetSource InSource) { | |||
| } | |||
| } | |||
|
|
|||
| bool CompareMaps( | |||
There was a problem hiding this comment.
This should go in the anonymous namespace.
There was a problem hiding this comment.
Also something like MapsAreEqual would be a better name than CompareMaps, because the latter doesn't indicate as clearly what it means when the function returns true or false.
|
Thanks @azrogers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support use cases like #737, this change adds a
RequestHeadersproperty to theCesium3DTileset, which passes these headers through to the tileset loader for them to be attached to each request made. Depends on CesiumGS/cesium-native#1057.