Make cesium-unity compatible with the shared asset changes in cesium-native. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azrogers seems like the previous CI failures were flubs, so don't worry about them anymore. I'll give this a lookover later today. |
|
This looks good to me. I did a quick test for the memory profiling just to make sure there was nothing weird happening under the hood, and didn't see any deviation in the texture memory stats. Thanks @azrogers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've discussed previously, we're not intending to fully implement the shared assets system in Unity at this point, as there are currently higher priority items that we need to get to. However, the changes made in cesium-native to support shared assets currently break the cesium-unity build. This change is the absolute minimum required to get cesium-unity working with the shared-assets branch of cesium-native. It doesn't implement the shared asset depot or change texture creation in any way.