Install debug vcpkg libraries from debug/lib
#962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lilleyse I'm going to move this out of this week's release just to avoid adding any more risk to the Cesium for Unreal release, which is already a pretty risky one. Let me know if there's any reason I'm not aware of that it does need to ship this month. |
|
@kring that's fine |
kring
added a commit
to CesiumGS/cesium-unreal
that referenced
this pull request
Nov 10, 2024
|
I just tried this out in cesium-unreal, and (perhaps unsurprisingly) it causes linker errors due to mismatched debug / release CRT. This is frustrating because our overlay triplet specifies: But it seems that something - perhaps individual libraries - are ignoring or overriding this. |
|
I believe I have the Unreal issues fixed in CesiumGS/cesium-unreal#1543. Once CI confirms that, I'll merge this. Thanks @lilleyse! |
kring
added a commit
to CesiumGS/cesium-unreal
that referenced
this pull request
Nov 12, 2024
Update build to work with changes in CesiumGS/cesium-native#962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug vcpkg libraries should be installed from the
debug/libdirectory, not thelibdirectory.