Make CesiumGltf headers public and fix warnings #1099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kring
reviewed
Feb 24, 2025
| @@ -103,20 +103,23 @@ class CESIUMUTILITY_API SharedAsset : public CesiumUtility::ExtensibleObject { | |||
| * useful to assign the data in derived classes. | |||
| */ | |||
| SharedAsset& operator=(const SharedAsset& rhs) { | |||
| CesiumUtility::ExtensibleObject::operator=(rhs); | |||
| if (rhs != this) { | |||
There was a problem hiding this comment.
This doesn't look right, comparing an instance to a pointer. Shouldn't it be:
Suggested change
| if (rhs != this) { | |
| if (&rhs != this) { |
Same with the move assignment operator below.
|
Unfortunately I think I'm going to have to scrap this PR and make a new one since we're no longer going with the |
|
No need to rush this into this release, moving it out. |
|
Closing in favor of #1133. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460. As part of #1004 we stopped marking most of the public headers as
SYSTEMso that they would be analyzed by clang-tidy, but we skipped overCesiumGltfas the number of warnings didn't seem worth resolving at the time. I ended up fixing some of those warnings while working on #1085, so I decided to finish the job here.