Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Examples Release CI #127

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

nivcertora
Copy link
Contributor

No description provided.

@nivcertora nivcertora requested a review from a team August 12, 2024 06:31
@nivcertora nivcertora self-assigned this Aug 12, 2024
Comment on lines 135 to 142

- run:
name: Install ReportAnalysis package and execute ReportAnalyzer
command: |
pip3.11 install git+ssh://[email protected]/Certora/ReportAnalysis.git
ReportAnalyzer --ci_client "Examples Nightly"
when: on_fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this in master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@yoav-el-certora yoav-el-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request

@nivcertora nivcertora merged commit 19c989a into master Aug 12, 2024
@nivcertora nivcertora deleted the niv/Align-Beta-And-Release-Config branch August 12, 2024 06:54
liav-certora added a commit that referenced this pull request Sep 9, 2024
* Remove Report Analysis depedency (#119)

* adding the example

* Nurit comments

* Fix Examples Release CI (#127)

* Fix Examples Release CI

* Address review

* update init axioms for some specs

* Revert "update init axioms for some specs" (#128)

This reverts commit 4cd2bbb.

* Update ERC4626.spec

* .

---------

Co-authored-by: yoav-el-certora <[email protected]>
Co-authored-by: Niv vaknin <[email protected]>
Co-authored-by: Naftali Goldstein <[email protected]>
liav-certora added a commit that referenced this pull request Sep 29, 2024
* Remove Report Analysis depedency (#119)

* Fix Examples Release CI (#127)

* Fix Examples Release CI

* Address review

* update init axioms for some specs

* Revert "update init axioms for some specs" (#128)

This reverts commit 4cd2bbb.

* .

* Update CVLByExample/ExtensionContracts/README.md

Co-authored-by: Nurit Dor <[email protected]>

* Update CVLByExample/ExtensionContracts/ExtensionContracts.spec

Co-authored-by: Nurit Dor <[email protected]>

* .

---------

Co-authored-by: yoav-el-certora <[email protected]>
Co-authored-by: Niv vaknin <[email protected]>
Co-authored-by: Naftali Goldstein <[email protected]>
Co-authored-by: Nurit Dor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants