improvement: prevent constant update of scan coordinate preview #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this (1) set_live_scan_coordinates will be called even if the stage is not moving (2) set_live_scan_coordinates can happen too frequently - problematic for big scan area coverage
hongquanli
changed the title
ianohara
reviewed
Jan 4, 2025
| @@ -3074,6 +3074,12 @@ def __init__( | |||
| self.eta_seconds = 0 | |||
There was a problem hiding this comment.
I checked, and we only connect MoveUpdater.position_after_move to update_live_coordinates. It seems like if the position_after_move signal is correct (it only emits after the completion of a move), this might have worked. Did you check if it's working as expected?
Also, if it is working as expected, and we also want a "position_after_move_and_half_hz" or something, we could add that signal to the MovementUpdater. Then the logic for it will be isolated to MovementUpdater, and any other widget that needs a similar signal doesn't need to replicate the logic.
beniroquai
pushed a commit
to beniroquai/octopi-research
that referenced
this pull request
Jan 20, 2025
Adding tab for filter controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this (1) set_live_scan_coordinates will be called even if the stage is not moving (2) set_live_scan_coordinates can happen too frequently - problematic for big scan area coverage