Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified black.yml #53

Closed
wants to merge 1 commit into from

Conversation

sohamazing
Copy link
Contributor

fix formatting in black.yml so that github formatting tests properly run and pass for the entire codebase

@ianohara
Copy link
Collaborator

ianohara commented Jan 2, 2025

Hey @sohamazing , was this the issue or was it the missing -- on the line-length argument? #49 runs linting okay without this PR, so I think it might have been that (which should be fixed in master now)

@ianohara ianohara self-requested a review January 2, 2025 18:14
Copy link
Collaborator

@ianohara ianohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed - can be closed.

@@ -9,4 +9,5 @@ jobs:
- uses: actions/checkout@v4
- uses: psf/black@stable
with:
options: "line-length=120"
options: "--line-length 120"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this, the missing --, was the issue. It's fixed in master, so I don't think we need this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I just had noticed the PR's were not passing this test earlier.

@hongquanli hongquanli closed this Jan 2, 2025
beniroquai pushed a commit to beniroquai/octopi-research that referenced this pull request Jan 20, 2025
issue modify, when autoLevels turnoff, open live would cause displaying abnormal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants