Flexible scan grid #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sohamazing
commented
Dec 4, 2024
•
sohamazing
commented
- removes legacy multipointwidget and grid acquisition
- multiPointWidget2 -> flexibleMultiPointWidget
- multiPointWidgetGrid -> wellplateMultiPointWidget
- must have ENABLE_WELLPLATE_MULTIPOINT or ENABLE_FLEXIBLE_MULTIPOINT
- flexible multipoint now
- uses pre-calculated fov coordinates to run acquistion
- dislpays scan grid for fov coordinates
- no longer uses manual dx and dy
- uses Nx, Ny, Overlap, Objective to create scan grid
- pass ObjectiveStore to flexible multipoint widget
- toggles scan grid correctly on NavigationViewer display for flexible and wellplate acquisitions (when tab changed)
- cleanup codebase (multipointWorker and milutpointController) to only use coordinate acquisition
- cleanup flexible multipoint widget UI
hongquanli
requested changes
Dec 4, 2024
software/control/widgets.py
Outdated
| class MultiPointWidget(QFrame): | ||
| class FlexibleMultiPointWidget(QFrame): |
There was a problem hiding this comment.
Can you switch the order of WellPlateMultiPointWidget and FlexibleMultiPointWidget? Current order deletes a lot of code and re-add a lot of code. Please try to avoid this kind of scenario.
There was a problem hiding this comment.
this is the old multipoint widget that is deleted
sohamazing
commented
Dec 5, 2024
hongquanli
reviewed
Dec 6, 2024
software/control/widgets.py
Outdated
|
|
||
| signal_acquisition_started = Signal(bool) | ||
| signal_acquisition_channels = Signal(list) | ||
| signal_acquisition_z_levels = Signal(int) | ||
| signal_acquisition_shape = Signal(int, int, int, float, float, float) | ||
| signal_acquisition_shape = Signal(int, float) |
There was a problem hiding this comment.
@sohamazing can you add in-line documentation here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.