Skip to content

Commit

Permalink
fix(stage): pass in PriorStage config when using Prior (#88)
Browse files Browse the repository at this point in the history
Stages need a config. We should make the `PriorStage` config
non-optional, but for now just make sure to pass it in.
  • Loading branch information
ianohara authored Feb 3, 2025
1 parent 04b65fb commit 67507d8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion software/control/gui_hcs.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def loadObjects(self, is_simulation):
)

if USE_PRIOR_STAGE:
self.stage: squid.abc.AbstractStage = squid.stage.prior.PriorStage(sn=PRIOR_STAGE_SN)
self.stage: squid.abc.AbstractStage = squid.stage.prior.PriorStage(sn=PRIOR_STAGE_SN, stage_config=squid.config.get_stage_config())

else:
self.stage: squid.abc.AbstractStage = squid.stage.cephla.CephlaStage(
Expand Down
4 changes: 0 additions & 4 deletions software/squid/stage/prior.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
from squid.abc import AbstractStage, Pos, StageStage
from squid.config import StageConfig


# NOTE/TODO(imo): We want to unblock getting the interface code implemented and in use, so to start we only
# implemented the cephla stage. As soon as we roll the interface out and get past the point of major refactors
# to use it (we want to get past that point as fast as possible!), we'll come back to implement this.
class PriorStage(AbstractStage):
def __init__(self, sn: str, baudrate: int = 115200, stage_config: StageConfig = None):
# We are not using StageConfig for Prior stage now. Waiting for further update/clarification of this part
Expand Down

0 comments on commit 67507d8

Please sign in to comment.