Add basic registration ratelimit #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The setup looks reasonable to me! The only thing I'd have to add is that the original CERT call also mentions a lack of throttling on the PW reset view (it's not very clearly written, but it is in there...), so you might want to apply something similar to that? |
|
Thanks, I missed that. Added. |
|
The message when trying to register to often is not customized yet: I think it would be good to do so, as most users won't know what "throttled" means. |
BeritJanssen
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tymees does this throttle implementation look reasonable?
Team, do we want
DEFAULT_THROTTLE_RATESin common or local settings? And what's a rate that's high enough for potential peak registration periods (like a course/lecture)?