Fix NER check #1667
Merged
Fix NER check #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeritJanssen
requested review from
JeltevanBoheemen and
lukavdplas
and removed request for
JeltevanBoheemen
lukavdplas
approved these changes
Oct 2, 2024
| @@ -264,14 +266,15 @@ def clean(self): | |||
|
|
|||
| @property | |||
| def has_named_entities(self): | |||
| client = elasticsearch(self.es_index) | |||
| from es.search import total_hits | |||
There was a problem hiding this comment.
Is there a reason this line isn't at the top of the file?
There was a problem hiding this comment.
Yes, otherwise it's a circular import, as the es.search module imports addcorpus.models.CorpusConfiguration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the existence of named entities was retrieved from the mappings. I decided to replace this by a search with a query to check if any fields starting with "ner:*" are actually in the documents. Less wordy this way, and with
size=0, this request takes only 2-7 milliseconds to perform on the largest corpus we have at the moment (dutchnewspapers-all).