Feature/peace corpora #1313
Merged
Feature/peace corpora #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukavdplas
reviewed
Nov 15, 2023
|
A general comment: I'd recommend adding a test like this one for the new corpus definitions: |
Co-authored-by: Luka van der Plas <[email protected]>
This reverts commit 4914e1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1288: Integrates the Peace Portal corpora. Also closes #1106 .
I decided to move the
NLTK_DATAvariable to the Django settings so it can be overridden more easily for tests (and no shifting around of existing data is necessary). Should this solution overlook some problems leading to the decision to place them in the es_settings module: the corresponding commit can be reverted.