Feature/corpus updates #1290
Merged
Feature/corpus updates #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukavdplas
reviewed
Oct 12, 2023
| @@ -1,4 +1,4 @@ | |||
| def main_content_mapping(token_counts=True, stopword_analysis=False, stemming_analysis=False, updated_highlighting=False): | |||
There was a problem hiding this comment.
I agree that the new version should be the default, but this code is only here to keep deprecated data in production. If the migration is done, this functionality can be removed entirely.
There was a problem hiding this comment.
At the moment, there are still corpora under migration, but indeed, the last argument should be removed eventually.
BeritJanssen
force-pushed
the
feature/corpus-updates
branch
from
67de470 to
86c524d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1281 . Additionally, the branch adjusts some corpus settings such as max dates.