Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/corpus descriptions #1270

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Feature/corpus descriptions #1270

merged 7 commits into from
Sep 25, 2023

Conversation

lukavdplas
Copy link
Contributor

@lukavdplas lukavdplas commented Sep 21, 2023

  • Adds/updates descriptions for the ECCO, Times, Guardian/Observer, and Periodicals corpora - thanks to our colleagues at the university library.
  • Merges the newspapers/periodicals categories for corpora. This is a suggestion from Arja: older media don't have a clear distinction between newspapers and magazines.
  • Changes the image for the Times corpus - I thought the current image (of the palace of westminster) would be confusing if times and parliament-uk are active in the same environment.

image changed to avoid confusion with parliament-uk corpus
@lukavdplas lukavdplas force-pushed the feature/corpus-descriptions branch from 23c945a to 176d61e Compare September 21, 2023 14:47
Copy link
Contributor

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lukavdplas lukavdplas merged commit 4aa606a into develop Sep 25, 2023
@lukavdplas lukavdplas deleted the feature/corpus-descriptions branch September 25, 2023 08:02
@lukavdplas lukavdplas added enhancement improvements to user functionality corpus changes to corpus definitions or new corpora labels Sep 26, 2023
@lukavdplas lukavdplas mentioned this pull request Nov 6, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
corpus changes to corpus definitions or new corpora enhancement improvements to user functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants