Feature/parallelize ngrams #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeritJanssen
force-pushed
the
feature/parallelize-ngrams
branch
from
9cd2899 to
9b0ef82
Compare
lukavdplas
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Nice! 😄
Note: I have not tried running this code, but I trust that you did. The code looks good (pending the failing test)!
A small nitpick on code quality: there are a lot of one-letter abbreviations as variable names (e.g. for r in results vs. for result in results), which I personally find detrimental to readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1005 .