Feature/corpus model validation #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use enums for mapping/visualisation types
lukavdplas
added
code quality
JeltevanBoheemen
approved these changes
Sep 14, 2023
- change mapping types to enum values - move forbidden field names to constants Co-Authored-By: Jelte van Boheemen <[email protected]>
lukavdplas
force-pushed
the
feature/corpus-model-validation
branch
from
97283d4 to
ceba0fb
Compare
lukavdplas
added
the
affects-elasticsearch-index
|
Labelled "affects elasticsearch index" because the DBNL mapping is adjusted and requires re-indexing. This should be possible without extracting from source data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more validation functions to corpus models. This includes a few "soft checks" where the validator raises a warning instead of an error.
I also corrected one genuine error in the definition of DBNL.
addresses this point