Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [74] 날짜 선택 범위 수정, 8/25 QA 반영 #75

Merged
merged 7 commits into from
Aug 28, 2024
Merged

refactor: [74] 날짜 선택 범위 수정, 8/25 QA 반영 #75

merged 7 commits into from
Aug 28, 2024

Conversation

JunYoungKr
Copy link
Collaborator

PR 유형

어떤 변경사항인지 체크해주세요 (중복 체크 가능)

  • 버그 (bug)
  • 기능 (feat)
  • 수정 (fix)
  • 리팩토링 (개선 느낌) (refactor)
  • 문서 (docs)
  • 기타

PR 설명

  • 날짜 선택 관련 요구사항 반영
  • 이벤트 생성
    • 기본값 설정
      • 시작일: 오늘
      • 마감일: 오늘 + 7일
      • 발표일: 오늘 + 7일
      • 전체: 오늘 + 3개월까지만 활성화
  • 이벤트, 설문 카드 border-radius 수정 (08/25 QA 요구사항 반영)

관련 이슈

스크린샷

체크리스트

  • 코드가 정상적으로 컴파일되고 모든 테스트를 통과했습니다
  • 변경사항에 대한 테스트를 추가했습니다 (버그 수정 / 기능 추가의 경우)
  • 관련 문서를 업데이트했습니다

추가 정보

@JunYoungKr JunYoungKr self-assigned this Aug 25, 2024
@JunYoungKr JunYoungKr linked an issue Aug 25, 2024 that may be closed by this pull request
[REFACTOR] 이벤트 날짜 선택 수정 #74
Closed
joseph0926
joseph0926 reviewed Aug 26, 2024
View reviewed changes
web/src/components/common/SurveyTimeInput.tsx Outdated Show resolved Hide resolved
web/src/components/myevent/ProcessingEventCard.tsx Show resolved Hide resolved
web/src/pages/home-page.tsx Outdated Show resolved Hide resolved
joseph0926
joseph0926 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@joseph0926 joseph0926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@JunYoungKr
Copy link
Collaborator Author

고생하셨습니다~

감사합니다~!

@JunYoungKr JunYoungKr merged commit a0584dc into dev Aug 28, 2024
2 checks passed
@joseph0926 joseph0926 deleted the refactor/74 branch August 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph0926 joseph0926 joseph0926 approved these changes

Assignees

@JunYoungKr JunYoungKr

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 이벤트 날짜 선택 수정
2 participants
@JunYoungKr @joseph0926