Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [63] 로딩 상태 추가 / 자잘한 버그 수정 #64

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

joseph0926
Copy link
Contributor

PR 유형

어떤 변경사항인지 체크해주세요 (중복 체크 가능)

  • 버그 (bug)
  • 기능 (feat)
  • 수정 (fix)
  • 리팩토링 (개선 느낌) (refactor)
  • 문서 (docs)
  • 기타

PR 설명

관련 이슈

스크린샷

체크리스트

  • 코드가 정상적으로 컴파일되고 모든 테스트를 통과했습니다
  • 변경사항에 대한 테스트를 추가했습니다 (버그 수정 / 기능 추가의 경우)
  • 관련 문서를 업데이트했습니다

추가 정보

@joseph0926 joseph0926 self-assigned this Aug 11, 2024
@joseph0926 joseph0926 linked an issue Aug 11, 2024 that may be closed by this pull request
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아예 새로 만드신걸까요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네네 form이랑 연결하려하니 기존껄 너무 많이 바꿔야해서 준영님 작업이랑 겹칠까봐,,

web/src/components/auth/sign-up2.tsx Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이메일 전송할 시간 동안 보여줄 spinner인가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 맞습니다!
조금 길어서,,

@joseph0926 joseph0926 merged commit e01318a into dev Aug 11, 2024
2 checks passed
@joseph0926 joseph0926 deleted the feature/63 branch August 11, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 로딩, 에러 컴포넌트 추가
2 participants