[SVCS-256] Adding "undecoded_path" to providers #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
requested changes
Sep 8, 2017
| @@ -62,6 +62,9 @@ class ProviderHandler(core.BaseHandler, CreateMixin, MetadataMixin, MoveCopyMixi | |||
|
|
|||
| self.auth = await auth_handler.get(self.resource, provider, self.request) | |||
| self.provider = utils.make_provider(provider, self.auth['auth'], self.auth['credentials'], self.auth['settings']) | |||
| # Find start of provider name, and start of ? marker and pull out file name from between them. | |||
| self.provider.undecoded_path = self.request.uri[self.request.uri.rfind(self.path_kwargs['provider'] + '/') + (len(self.path_kwargs['provider'])): self.request.uri.rfind("?")] | |||
There was a problem hiding this comment.
Please break down the components of this indexing operation into individual variables with descriptive names. This is hard to skim.
There was a problem hiding this comment.
Indexing issue:
http://localhost:7777/v1/resources/p8a63/providers/googledrive/me%2fow/provider/googledrive/beef?meta=
self.provider.undecoded_path is beef.
There was a problem hiding this comment.
Indexing issue:
http://localhost:7777/v1/resources/p8a63/providers/googledrive/me%2fow/provider/googledrive/beef
self.provider.undecoded_path is bee
Currently, a URL can get encoded and decoded many times. This can cause the original name of a file to be near impossible to figure out if it uses special characters. This variable will help solve this problem.
AddisonSchiller
force-pushed
the
feature/url_decode
branch
from
a19fc66
to
a8717a5
Compare
|
Added requested Changes |
AddisonSchiller
changed the title
|
@AddisonSchiller Might want to wrap up this conflict. |
cslzchen
requested changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://openscience.atlassian.net/browse/SVCS-256
Purpose
We need the un-decoded file name to distinguish between files with special characters.
ie: "me/ow.txt and me%2Fow.txt" The decoding tornado does makes these files hard to distinguish.
Summary of changes
Added an "undecoded_path" variable to the base_provider. This gets set in the "prepare" function to be the undecoded_path received from the request. The path is pulled from 'self.request.uri'
QA
QA will come on individual tickets for providers