Enable session sharing between GV and OSF #227
+130
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed shared session issues and hmac auth
brianjgeiger
approved these changes
Feb 10, 2025
Comment on lines
14
to
+16
| UserReference.objects.get_or_create(user_uri=_user_uri) | ||
| request.session["user_reference_uri"] = _user_uri | ||
| if not request.session.get("user_reference_uri"): | ||
| request.session["user_reference_uri"] = _user_uri |
There was a problem hiding this comment.
Do you need to get_or_create the UserReference if it's already on the session? Might be able to save a db call here if not.
There was a problem hiding this comment.
Probably you still do need to do that, as I think about it more.
There was a problem hiding this comment.
I tried to run the scenario in my mind, I think we do. Here a potential scenario immediately after deployment to prod:
- A logged out user logs into OSF,
user_reference_uriis set on the shared session - User (now authenticated) then makes a call to GV, at this point a
UserReferenceinstance is not yet created for this user on the GV side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.