Only refresh token if the token have expired when returning wb creds #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also fix the migration management command
opaduchak
requested changes
Feb 4, 2025
| and addon.base_account.oauth2_token_metadata.access_token_expiration | ||
| and addon.base_account.oauth2_token_metadata.access_token_expiration | ||
| < timezone.now() | ||
| ): | ||
| addon.base_account.refresh_oauth_access_token__blocking() |
There was a problem hiding this comment.
Nit: maybe we can alter logic of refresh_oauth_access_token method for it to refresh token only if it is expired (we may also add a parameter force: bool, which would allow to bypass this limitation if needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suspect that constant calls to external services to refresh tokens is behind the reason why performance is slow on staging and test. So we should only refresh tokens when we need to.