Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update taxonomy-top-list qp #762

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Sep 18, 2023

Purpose

  • Update query-params for links going to preprint discover page

Summary of Changes/Side Effects

  • Update query-params for landing page search textbox
  • Update query-params for landing page "Browse by subjects" links (taxonomy-top-list)
    • No need to update additional-provider-list, as we will be dropping livedata preprint-provider and that's the only provider on Production that seems to have additional_provider

Testing Notes

Ticket

https://openscience.atlassian.net/browse/IN-

Notes for Reviewer

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@futa-ikeda futa-ikeda merged commit 377f3d7 into CenterForOpenScience:feature/search-improvements Sep 18, 2023
2 checks passed
futa-ikeda added a commit that referenced this pull request Oct 10, 2023
* Reroute users to new search page (#750)

* [ENG-4572] Delete discover route (#752)

* delete discover route

* add stub for theme service

* point to new eosf feature branch (#758)

* Skip failing test for now

* Update taxonomy-top-list qp (#762)

* Fix qp values for browse by subject links (#763)

* Update yarn.lock

* update eof to use 0.39.0 (#764)

---------

Co-authored-by: Yuhuai Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants