Fix crash when screen scale factor greater than 1

CefView · Sep 29, 2022 · 47ebc27 · 47ebc27
1 parent 1b67503
commit 47ebc27
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/QCefView.cpp b/src/QCefView.cpp
@@ -28,6 +28,9 @@ QCefView::QCefView(const QString url, const QCefSetting* setting, QWidget* paren
 
   setMouseTracking(true);
   setFocusPolicy(Qt::WheelFocus);
+
+  // create browser
+  d_ptr->createCefBrowser(this, url, setting);
 }
 
 QCefView::QCefView(QWidget* parent /*= 0*/)
@@ -37,6 +40,11 @@ QCefView::QCefView(QWidget* parent /*= 0*/)
 QCefView::~QCefView()
 {
   qDebug() << this << "is being destructed";
+
+  if (d_ptr) {
+    d_ptr->destroyCefBrowser();
+    d_ptr.reset();
+  }
 }
 
 void

diff --git a/src/details/QCefViewPrivate.cpp b/src/details/QCefViewPrivate.cpp
@@ -52,14 +52,10 @@ QCefViewPrivate::QCefViewPrivate(QCefContextPrivate* ctx,
   sLiveInstances.insert(this);
 
   isOSRModeEnabled_ = pContextPrivate_->cefConfig()->WindowlessRenderingEnabled().toBool();
-
-  createCefBrowser(view, url, setting);
 }
 
 QCefViewPrivate::~QCefViewPrivate()
 {
-  destroyCefBrowser();
-
   sLiveInstances.remove(this);
 }