Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantroid-778 Missing translations in PocketPaint [Also Resolves UX-197] #1343

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sharma-Ji-21
Copy link

@Sharma-Ji-21 Sharma-Ji-21 commented Jan 3, 2025

Title: PAINTROID-778: Fix Missing Translations in PocketPaint [Also Resolves UX-197]

Description:
This PR addresses the missing German translations in the PocketPaint application as outlined in Jira ticket PAINTROID-778 and partially overlaps with UX-197.

Changes Made:
• Updated translations for the following elements in both the tutorial and toolbox:
• Smudge → Verschmieren
• Clipboard → Zwischenablage
• Cliparea → Ausschneiden
• Updated the Color Picker translation:
• Recently Used → zuletzt verwendet
• Verified changes for consistency in the UI and ensured that all elements reflect the correct translations.

Additional Context:
• Before and after screenshots have been included to highlight the changes.
• These fixes not only resolve translation gaps but also improve user experience by maintaining linguistic consistency.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title

  • Include a summary of the changes plus the relevant context

  • Choose the proper base branch (develop)

  • Confirm that the changes follow the project’s coding guidelines

  • Verify that the changes generate no compiler or linter warnings

  • Perform a self-review of the changes

  • Verify to commit no other files than the intentionally changed ones

  • Include reasonable and readable tests verifying the added or changed behavior

  • Confirm that new and existing unit tests pass locally

  • Check that the commits’ message style matches the project’s guideline

  • Stick to the project’s gitflow workflow

  • Verify that your changes do not have any conflicts with the base branch

  • After the PR, verify that all CI checks have passed

  • Post a message in the #paintroid Slack channel and ask for a code reviewer

    Before:
    image
    image

       After:
    

image
image

@Sharma-Ji-21
Copy link
Author

Comment on PR #1343
@JulianJautz @juliajulie95

Hi team,

I wanted to provide an update regarding the test results for this PR:
• ✅ 582 test cases passed,
• ⏸ 2 test cases were skipped, and
• ❌ 5 test cases failed.

After investigating, I managed to fix ✅ 1 of the failed test cases. However, ❌ 4 test cases are still failing.

To ensure these issues weren’t introduced by my changes, I cloned the original repository without any modifications and reran the test suite. The results were the same:
• ✅ 582 passed,
• ⏸ 2 skipped, and
• ❌ 4 failed.

This suggests the failing test cases are likely pre-existing issues. Could you please confirm if these failures are known or provide guidance on how to proceed?

Looking forward to your feedback!

Best regards,
Om Sharma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant