Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-693 File not found when loading temporary copies #1322

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

PAINTROID-693 File not found when loading temporary copies #1322

wants to merge 2 commits into from

Conversation

JulianJautz
Copy link
Contributor

@JulianJautz JulianJautz commented Nov 27, 2023 •
edited
Loading

Removed bug where path to temp file was set incorrectly and therefore image could not be loaded.

  • streamlined saving and loading of temp file
  • closed streams

https://jira.catrob.at/browse/PAINTROID-693

in addition, avoided kryo buffer underflow when app is started and no temp file available
should solve:
https://jira.catrob.at/browse/PAINTROID-655

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

PAINTROID_693_auto_load_file_not_found
31116f0 
removed bug where path to temp file was set incorrectly

- streamlined saving and loading of temp file
- closed streams
- avoid kryo buffer underflow when app is started and no temp file available
@JulianJautz JulianJautz changed the title PAINTROID_693_auto_load_file_not_found PAINTROID-693 File not found when loading temporary copies Nov 27, 2023
PAINTROID_693_auto_load_file_not_found
16c459f 
removed bug where path to temp file was set incorrectly

- streamlined saving and loading of temp file
- closed streams
- avoid kryo buffer underflow when app is started and no temp file available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JulianJautz