Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAINTROID-342 Add system integration tests and create test suite #1298

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

foenabua
Copy link
Contributor

@foenabua foenabua commented Jul 20, 2023

https://jira.catrob.at/browse/PAINTROID-342

IMPORTANT: The newly added tests can only be executed succesfully on an device/emulator with Android API 29 or higher. The emulator on Jenkins uses API 28 and therefore the tests fail. Until the image is updated to a newer API the tests will not run successfully.

  • added new tests as defined in ticket
  • There are now two test suites that are executed on Jenkins in two different stages. One executes only the newly added MediaGalleryTests and the other the rest of the Instrumented tests.
  • In the ticket it is defined that the new tests should only be executed in the midnight builds and manually. However, in the current imlementation the tests are generally executed when built from develop branch. If this needs to be changed, please leave a comment.
  • As suggested in the ticket, I orienteded myself on the test suites implementation in Catroid. The class AndroidPackageRunner is directly copied from the Catroid Repo.
  • Failure of MediaGalleryTests stage is reported to Slack on "system-tests"

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant