Paintroid 451 : Flutter: advanced Options

[vishad-tyagi]

Ticket
https://catrobat.atlassian.net/browse/PAINTROID-451
Paintroid-451 : Flutter: advanced Options

Description
Add the functionality for the advanced options in the overflow menu.

New Features and Enhancements

• New Features and Enhancements

Refactorings and Bug Fixes

• Refactorings and Bug Fixes

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

• Include the name of the Jira ticket in the PR’s title
• Include a summary of the changes plus the relevant context
• Choose the proper base branch (develop)
• Confirm that the changes follow the project’s coding guidelines
• Verify that the changes generate no compiler or linter warnings
• Perform a self-review of the changes
• Verify to commit no other files than the intentionally changed ones
• Include reasonable and readable tests verifying the added or changed behavior
• Confirm that new and existing unit tests pass locally
• Check that the commits’ message style matches the project’s guideline
• Stick to the project’s gitflow workflow
• Verify that your changes do not have any conflicts with the base branch
• After the PR, verify that all CI checks have passed
• Post a message in the #paintroid Slack channel and ask for a code reviewer

[msesko]

Hi @vishad-tyagi. Good job on the UI. Check comments for changes.

Is this ticket UI only? @juliajulie95 Or do you also have ti implement the antialiasing and soothing? Would make sense to me.

• tests are needed for UI
• tests for functionality in case it has to be implemented

[msesko]

Also state is not saved. If I close the UI and reopen the switches states are not saved.

[vishad-tyagi]

@msesko I worked on the Information provided in the ticket. I commented for more information too. After that, I took as much as I could from the Android version of the app on the Play Store. (I know Catrobat is open source and run by many students, I just don't want you to think, that I did the minimum 🙂). Just let me know what other functionality are to be added. I will commit to all the changes ASAP. Regarding the state save functionality, the specifications for the two options were not clearly defined in the ticket. Consequently, I refrained from incorporating the state change variable, anticipating that this aspect might be addressed in a future ticket.
Sorry for the late response, my mid-sem exams are going on.

[Lenkomotive]

Hi @vishad-tyagi. Good job on the UI. Check comments for changes.

Is this ticket UI only? @juliajulie95 Or do you also have ti implement the antialiasing and soothing? Would make sense to me.

• tests are needed for UI
• tests for functionality in case it has to be implemented

The ticket-description does not clearly state the scope of the ticket. Imo the actual implementation of the algorithms would exceed the scope of the ticket. Id say we treat it as UI only for now and create new tasks for each algorithm to be implemented later.

[juliajulie95]

Indeed, I would not want to add UI without working functionality behind it.
We could maybe define the ticket more clearly and implement one of the two options to keep the ticket smaller?

[msesko]

Indeed, I would not want to add UI without working functionality behind it. We could maybe define the ticket more clearly and implement one of the two options to keep the ticket smaller?

It would be nice to specify if it is UI only ticket or functionality as well for this type of features.

But even if it is a UI feature it should be prepared in a way that the backend functionality can just be plugged into it (no hardcoded vals where we should have vars, correct passing in of vars, correctly managing states etc.)

Such ticket would also be 454 - Layers, where the UI in itself is quite a lot to code and would be easier to review if separated.

[vishad-tyagi]

@msesko I have implemented the changes, if any more changes are required let me know (like _showAdvancedOptionsDialog() should be in io_handler instead of overflown_menu, etc)

[juliajulie95]

Please resolve conflicts