PAINTROID-696: If no projects available, create new one when tapping edit icon #48
Conversation
|
Can we optionally show a |
There was a problem hiding this comment.
@bhav-khurana Thanks for the great suggestion. I also think that showing plus icon makes more sense instead of edit when there are no saved project.
| Icons.more_vert, | ||
| ); | ||
| expect(overflowMenuButtonFinder, findsOneWidget); | ||
|
|
There was a problem hiding this comment.
I think it would also be nice if you check if the canvas is clear. Might help in the future to detect regressions.
| expect(find.text('My Projects'), findsOneWidget); | ||
| }, | ||
| ); | ||
|
|
There was a problem hiding this comment.
Please also add a test for opening a saved project.
Some designs: Reference: Personally I do not like the look of a plus (add) icon in there. Makes it look like a hospital app haha. Tbh I think the pencil icon is also nice for adding. What do you guys think? @bakicelebi @bhav-khurana |
|
@msesko I would agree.. the plus icon doesn't seem that appropriate now.. The pencil icon looks better imo |
|
The design language is clearer with plus icon because pencil icon can be edit or new, whereas the plus icon is specifically creating something new. Additionally we are also using plus in the bottom right corner for creating a new project. Lets make the UI experience unified :) |
It's ugly tho 😭 |
|
@bhav-khurana Thanks for the suggestion, as @bakicelebi pointed out, it does make the design language clearer. Personally I like the white '+' on grey background more, as it resembles the same design of the current pen icon we use. :) |
|
I think we can go with the |
|
please link to jira and resolve conflicts |
|
Is this still a draft? |
Title says it all; If no projects available, create new one when tapping edit icon.
New Features and Enhancements
Refactorings and Bug Fixes
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.